kobotoolbox / kpi / 16301206110

81%

master: 76%

push

github

fix(table): show hard coded error message for `500`'s DEV-707 (#5918)

### 📣 Summary
Fixes a regression introduced in #5903 where the error message intended
for `500`'s was displaying for empty forms, undeployed forms, and/or
deployed forms with no data. Reverts the behaviour to show the response
text in these cases

### 👀 Preview steps

1. ℹ️ have an account and 2 projects
2. leave both projects empty
3. deploy one project
4. check the data table for both projects
6. 🔴 [on main] notice that the "Oops!" message exists for both these
projects
7. 🟢 [on PR] notice that the error messages are correct and relevant to
the issue (not deployed, or no submissions) and there is no toast
notification
8. add `1/0` to line 444 on `data.py`
9. 🟢 notice that the data table still does not show an a mess of html
and there is a detailed toast notification
10. remove the `1/0` in `data.py`
11. submit some data in a form, or navigate to a form with data
9. 🟢 notice that the data table displays as expected

---------

Co-authored-by: Paulo Amorim <pauloamorimbr@gmail.com>

6147 of 9740 branches covered (63.11%)

23203 of 28726 relevant lines covered (80.77%)

0.81 hits per line