Unleash / unleash / 16268229896

86%

master: 91%

Build Type

push

github

Committed by web-flow

Commit Message

chore: allow bulk metrics with empty flag names (#10353)

https://linear.app/unleash/issue/2-3695/allow-empty-flag-names-to-be-reported-in-bulk-metrics

Accepts metrics with empty flag names in the `/api/client/metrics/bulk`
endpoint.

When testing unknown flags through Edge, which uses the `/bulk`
endpoint, we noticed that there's a slight difference in validation
behavior compared to the regular metrics endpoint. While the regular
endpoint allows empty flag names, this one does not.

We can argue that we don't care about empty flag names in the first
place, which is true, but this inconsistency between the metric
endpoints can be confusing, and it also means that a single empty flag
name evaluation would break metrics being reported for that entire Edge
instance, for example.

This way we still accept it, just like we currently do if we point to
Unleash directly instead of going through Edge.

**Note**: We noticed that, due to the slightly different logic branch,
the bulk metrics endpoint does not report unknown flags. We'll take a
look at this at a later point.

Run Details

7089 of 7141 branches covered (99.27%)

1 of 1 new or added line in 1 file covered. (100.0%)

10 existing lines in 1 file now uncovered.

67056 of 73357 relevant lines covered (91.41%)

430.1 hits per line