PrincetonUniversity / PsyNeuLink / 16258233980

85%

master: 85%

push

github

llvm: Disambiguate seed data type (#3307)

The PNL global seed is initialized as np.uint32, but can be replaced by any other type by calling the set_global_seed function.
This creates issues during compilation as the seed needs to be represented as a float to support modulation.
Moreover, the issue manifests in a confusing way as a failed assertion that a Port other than OutputPort sees a data type mismatch between the existing and modulated value.

Add an assertion message better explaining the asserted failure.
Explicitly convert 'seed' and 'function-seed' parameter values to float when deriving compiled data types.
Convert the new seed value passed to set_global_seed to match the data type of the current seed (np.uint32) and add a new test to check the behaviour.
Cleanup and improve comments in the affected code paths.

9915 of 12970 branches covered (76.45%)

Branch coverage included in aggregate %.

20 of 20 new or added lines in 3 files covered. (100.0%)

34502 of 39589 relevant lines covered (87.15%)

0.87 hits per line