Ouranosinc / xsdba / 16257014088

78%

push

github

cluster_thresh in ExtremeValues as a Quantified (#179)

<!-- Please ensure the PR fulfills the following requirements! -->
<!-- If this is your first PR, make sure to add your details to the
AUTHORS.rst! -->
### Pull Request Checklist:
- [x] This PR addresses an already opened issue (for bug fixes /
features)
  - This PR fixes #xyz
- [x] (If applicable) Documentation has been added / updated (for bug
fixes / features).
- [x] (If applicable) Tests have been added.
- [x] CHANGELOG.rst has been updated (with summary of main changes).
- [x] Link to issue (:issue:`number`) and pull request (:pull:`number`)
has been added.

### What kind of change does this PR introduce?

* `cluster_thresh` is now a Quantified, so that different thresholds can
be specified.

### Does this PR introduce a breaking change?

Not in public functions. In some private functions, I changed the order
of arguments. There is an apply_ufunc and it made more sense to put
cluster_thresh upfront since it's now a DataArray too.

### Other information:

12 of 12 new or added lines in 2 files covered. (100.0%)

2776 of 3564 relevant lines covered (77.89%)

5.32 hits per line