agama-project / agama / 16171889594

74%

push

github

initialize InstallationPhase (bsc#1245760) (#2546)

## Problem

A race condition, an unattended installation sometimes stalls and this
is in the log:

> agama-web-server[3392]: Server return error Agama service error: D-Bus
service error:
> org.freedesktop.DBus.Error.Failed: nil is not a member of
0..4294967295; caused by
> 1 sender=:1.2 -> dest=org.opensuse.Agama.Manager1 serial=104
reply_serial=
> path=/org/opensuse/Agama/Manager1;
interface=org.freedesktop.DBus.Properties; member=Get error_name=

The message does not mention the offending property, but from the
context of the request we find it is `CurrentInstallationPhase`.

- https://bugzilla.suse.com/show_bug.cgi?id=1245760


## Solution

It turns out that `InstallationPhase` is not initializing itself
properly, exposing an uninitialized `nil` value for some short(?) time.
So initialize it.

## Testing

No, but I dare say the fix is simple enough


## Screenshots

No

## Documentation

This fix does not need docs

1887 of 3409 branches covered (55.35%)

Branch coverage included in aggregate %.

1 of 1 new or added line in 1 file covered. (100.0%)

23752 of 36472 relevant lines covered (65.12%)

47.24 hits per line