agama-project / agama / 16144413222

74%

Build Type

push

github

Committed by web-flow

Commit Message

feat: notify the user when the auto-installation cannot be started (#2534)

## Problem

Until now, Agama does not notify the user when the configuration for an
unattended installation cannot be loaded.

## Solution

### A partial solution

This is the first step towards having better handling of the
auto-installation process. It is not 100% complete, as it does not
report exactly the problem found when loading the profile, but we do not
want to invest more time into this at this point. We plan to do it
better for SLES 16.1.

### Replacing `agama-auto`

To implement this behavior, we decided to replace the old `agama-auto`
script with a new `agama-autoinstall` binary. The new binary can use all
the goodies from `agama-lib` and, in the future, it will not need to
rely on the command-line interface anymore.

### The behavior

If the user specifies an `inst.auto` and the profile could not be
loaded, Agama will display a sort of generic message asking the user
whether to retry. In the future, we would like to:

* Offer better diagnostics.
* Allow the user to specify a new URL.

If the user decides to not retry, Agama will not start the
auto-installation process.

If the user did not specify a `inst.auto`, Agama tries to silently load
one from the pre-defined locations.

### A new `inst.install` option

Setting `inst.install` to `0` makes Agama to stop before starting the
installation, after loading the configuration. It might be useful for
inspecting the result of applying the configuration before starting the
installation.

## Testing

- [x] Added a new unit test (partial)
- [x] Tested manually


## Screenshots

The text needs some improvements, but the screenshot is useful to get
the idea.


![config-load-error](https://github.com/user-attachments/assets/c6f31ed1-d826-47e5-bca2-7e473a67d7e9)


## Follow-up

- Document the new `inst.install` cmdline argument.
- Allow the user to specify a new URL.
- Do not rely on the CLI anymore.
- Extend the CLI to supp... (continued)

Run Details

1887 of 3409 branches covered (55.35%)

Branch coverage included in aggregate %.

1 of 2 new or added lines in 1 file covered. (50.0%)

5 existing lines in 1 file now uncovered.

23710 of 36325 relevant lines covered (65.27%)

47.42 hits per line