Unleash / unleash / 16140487579

86%

master: 91%

Build Type

push

github

Committed by web-flow

Commit Message

fix: make user creation transactional (#10327)

## About the changes
When inserting a user with an invalid role id, the user creation will
succeed but there will be no record in the audit log.

The API call returns a 400 misleading you to believe the user was not
created, but it actually was.

This makes the whole user creation transactional, so if something fails,
data will be in the right state.

## Testing
The e2e test was split in 2 scenarios, one with smtp and another one
without.

This test was added, and it was failing before adding the transaction,
because when fetching the users, the user was there, despite having
returned a 400 error in the API call:

https://github.com/Unleash/unleash/blob/80a2e65b6/src/test/e2e/api/admin/user-admin.e2e.test.ts#L181-L204

Run Details

6957 of 7010 branches covered (99.24%)

88 of 88 new or added lines in 4 files covered. (100.0%)

2 existing lines in 1 file now uncovered.

65269 of 73278 relevant lines covered (89.07%)

437.92 hits per line