16082515961
73%

Ran 05 Jul 2025 03:24AM UTC

Jobs 1

Files 1920

Run time 3min

Badge

Embed ▾

Committed 04 Jul 2025 08:23PM UTC coverage: 72.095% (-0.1%) from 72.193%

Build # 16082515961

Build Type

push

github

Committed by

poettering

Commit Message

seccomp-util: allowlist open_tree() as part of @file-system

Now that we make use of open_tree() in places we previously used
openat() with O_PATH, it makes sense to move it from @mount to
@file-system. Without the OPEN_TREE_CLONE flag open_tree() is after all
unprivileged.

Note that open_tree_attr() I left in @mount, since it's purpose is
really to set mount options when cloning, and that's clearly a mount
related thing, not so much something you could use unpriv.

Follow-up for: c5de7b14a

This addresses an issue tracked down by Antonio Feijoo: since the commit
that started to use open_tree() various apps started to crash because
they used seccomp filters and sd-device started to use open_tree()
internally.

Run Details

300842 of 417287 relevant lines covered (72.09%)

715300.57 hits per line

Uncovered Existing Lines

Lines	Coverage	∆	File
1	89.87	-0.18%	src/basic/compress.c
1	76.87	-0.68%	src/basic/io-util.c
1	78.04	-0.26%	src/basic/namespace-util.c
1	59.65	-0.06%	src/core/main.c
1	64.61	-0.04%	src/core/service.c
1	73.65	0.0%	src/import/import-fs.c
1	80.0	-20.0%	src/libsystemd/sd-id128/id128-util.h
1	92.13	-0.05%	src/libsystemd/sd-journal/journal-file.c
1	85.5	-0.05%	src/libsystemd/sd-journal/sd-journal.c
1	69.54	-0.24%	src/machine/machined-varlink.c
1	72.23	-0.09%	src/network/networkd-dhcp4.c
1	87.39	-0.23%	src/network/tc/qdisc.c
1	95.65	-4.35%	src/oom/oomd-util.h
1	77.36	-0.27%	src/shared/acl-util.c
1	67.0	-0.2%	src/shared/loop-util.c
1	81.19	-0.5%	src/systemctl/systemctl-start-unit.c
1	94.64	-0.11%	src/test/test-time-util.c
1	83.07	-0.53%	src/tpm2-setup/tpm2-setup.c
1	75.0	-0.27%	src/udev/udev-watch.c
2	42.86	0.0%	src/basic/cgroup-util.h
2	58.55	-1.32%	src/core/dbus-util.c
2	57.76	-0.41%	src/journal-remote/journal-upload.c
2	78.12	-0.41%	src/network/networkd-dhcp-server.c
2	47.01	-0.8%	src/shared/watchdog.c
2	67.42	-0.09%	src/tmpfiles/tmpfiles.c
3	91.07	0.51%	src/basic/unit-def.c
3	75.0	-2.68%	src/coredump/coredump-vacuum.c
3	76.49	-0.53%	src/core/transaction.c
3	64.56	-0.41%	src/libsystemd/sd-journal/journal-verify.c
4	85.79	-2.19%	src/core/bpf-devices.c
4	40.56	-0.31%	src/cryptsetup/cryptsetup.c
4	79.3	-1.76%	src/journal/journald-kmsg.c
4	48.13	-0.38%	src/nsresourced/nsresourcework.c
4	87.5	1.94%	src/test/test-mempress.c
4	74.57	-1.72%	src/validatefs/validatefs.c
5	85.46	-0.31%	src/network/networkd-link.c
5	81.1	-0.61%	src/resolve/resolved-link.c
6	76.5	-0.62%	src/shared/conf-parser.c
7	77.36	-0.38%	src/journal-remote/journal-upload-journal.c
7	80.09	-1.1%	src/network/networkd-manager.c
7	45.05	-1.01%	src/udev/udev-builtin-uaccess.c
7	82.86	0.3%	src/udev/udev-node.c
8	72.55	-0.36%	src/core/cgroup.c
8	65.92	-1.0%	src/fstab-generator/fstab-generator.c
8	70.13	-1.46%	src/journal-remote/journal-remote-main.c
9	94.4	1.6%	src/basic/rlimit-util.c
9	72.02	-0.98%	src/shared/mount-util.c
10	40.14	-0.69%	src/core/dbus-manager.c
11	84.62	2.37%	src/test/test-cgroup.c
12	45.25	-0.38%	src/core/load-fragment.c
13	40.34	-10.92%	src/core/emergency-action.c
13	37.5	-10.83%	src/systemctl/systemctl-start-special.c
13	93.94	0.16%	src/test/test-fs-util.c
13	0.0	0.0%	src/udev/mtd_probe/mtd_probe.c
14	65.62	-2.59%	src/core/timer.c
14	84.81	-1.85%	src/udev/udev-manager.c
20	0.0	0.0%	src/udev/v4l_id/v4l_id.c
21	80.64	-0.86%	src/core/manager.c
22	73.27	-1.22%	src/journal/journald-manager.c
23	58.2	-12.17%	src/resolve/resolved-resolv-conf.c
26	66.67	-1.27%	src/udev/udev-worker.c
27	69.3	-0.54%	src/repart/repart.c
31	69.23	-10.37%	src/udev/udev-builtin-blkid.c
32	79.73	-0.97%	src/core/unit.c
37	55.23	-1.14%	src/core/socket.c
54	6.16	-0.17%	src/udev/udev-builtin-keyboard.c
56	83.01	-1.52%	src/shared/tpm2-util.c
61	76.93	-9.08%	src/udev/udevadm-info.c
64	72.06	5.11%	src/analyze/analyze.c
84	0.0	0.0%	src/ssh-generator/ssh-generator.c
108	0.0	0.0%	src/udev/ata_id/ata_id.c
177	0.0	0.0%	src/udev/cdrom_id/cdrom_id.c
465	58.37	-2.26%	src/shared/bus-unit-util.c

Jobs

ID	Job ID	Ran	Files	Coverage
1	16082515961.1	05 Jul 2025 03:24AM UTC	1920	72.09	GitHub Action Run

systemd / systemd / 16082515961
73%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Uncovered Existing Lines

Jobs

Source Files on build 16082515961

systemd / systemd / 16082515961 73%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Uncovered Existing Lines

Jobs

Source Files on build 16082515961

systemd / systemd / 16082515961
73%

README BADGES
x