• Home
  • Features
  • Pricing
  • Docs
  • Announcements
  • Sign In

systemd / systemd / 16082515961

04 Jul 2025 08:23PM UTC coverage: 72.095% (-0.1%) from 72.193%
16082515961

push

github

poettering
seccomp-util: allowlist open_tree() as part of @file-system

Now that we make use of open_tree() in places we previously used
openat() with O_PATH, it makes sense to move it from @mount to
@file-system. Without the OPEN_TREE_CLONE flag open_tree() is after all
unprivileged.

Note that open_tree_attr() I left in @mount, since it's purpose is
really to set mount options when cloning, and that's clearly a mount
related thing, not so much something you could use unpriv.

Follow-up for: c5de7b14a

This addresses an issue tracked down by Antonio Feijoo: since the commit
that started to use open_tree() various apps started to crash because
they used seccomp filters and sd-device started to use open_tree()
internally.

300842 of 417287 relevant lines covered (72.09%)

715300.57 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

42.86
/src/basic/cgroup-util.h
1
/* SPDX-License-Identifier: LGPL-2.1-or-later */
2
#pragma once
3

4
#include "forward.h"
5

6
#define SYSTEMD_CGROUP_CONTROLLER_LEGACY "name=systemd"
7
#define SYSTEMD_CGROUP_CONTROLLER_HYBRID "name=unified"
8
#define SYSTEMD_CGROUP_CONTROLLER "_systemd"
9

10
/* An enum of well known cgroup controllers */
11
typedef enum CGroupController {
12
        /* Original cgroup controllers */
13
        CGROUP_CONTROLLER_CPU,
14
        CGROUP_CONTROLLER_CPUACCT,    /* v1 only */
15
        CGROUP_CONTROLLER_CPUSET,     /* v2 only */
16
        CGROUP_CONTROLLER_IO,         /* v2 only */
17
        CGROUP_CONTROLLER_BLKIO,      /* v1 only */
18
        CGROUP_CONTROLLER_MEMORY,
19
        CGROUP_CONTROLLER_DEVICES,    /* v1 only */
20
        CGROUP_CONTROLLER_PIDS,
21

22
        /* BPF-based pseudo-controllers, v2 only */
23
        CGROUP_CONTROLLER_BPF_FIREWALL,
24
        CGROUP_CONTROLLER_BPF_DEVICES,
25
        CGROUP_CONTROLLER_BPF_FOREIGN,
26
        CGROUP_CONTROLLER_BPF_SOCKET_BIND,
27
        CGROUP_CONTROLLER_BPF_RESTRICT_NETWORK_INTERFACES,
28
        /* The BPF hook implementing RestrictFileSystems= is not defined here.
29
         * It's applied as late as possible in exec_invoke() so we don't block
30
         * our own unit setup code. */
31

32
        _CGROUP_CONTROLLER_MAX,
33
        _CGROUP_CONTROLLER_INVALID = -EINVAL,
34
} CGroupController;
35

36
#define CGROUP_CONTROLLER_TO_MASK(c) (1U << (c))
37

38
/* A bit mask of well known cgroup controllers */
39
typedef enum CGroupMask {
40
        CGROUP_MASK_CPU = CGROUP_CONTROLLER_TO_MASK(CGROUP_CONTROLLER_CPU),
41
        CGROUP_MASK_CPUACCT = CGROUP_CONTROLLER_TO_MASK(CGROUP_CONTROLLER_CPUACCT),
42
        CGROUP_MASK_CPUSET = CGROUP_CONTROLLER_TO_MASK(CGROUP_CONTROLLER_CPUSET),
43
        CGROUP_MASK_IO = CGROUP_CONTROLLER_TO_MASK(CGROUP_CONTROLLER_IO),
44
        CGROUP_MASK_BLKIO = CGROUP_CONTROLLER_TO_MASK(CGROUP_CONTROLLER_BLKIO),
45
        CGROUP_MASK_MEMORY = CGROUP_CONTROLLER_TO_MASK(CGROUP_CONTROLLER_MEMORY),
46
        CGROUP_MASK_DEVICES = CGROUP_CONTROLLER_TO_MASK(CGROUP_CONTROLLER_DEVICES),
47
        CGROUP_MASK_PIDS = CGROUP_CONTROLLER_TO_MASK(CGROUP_CONTROLLER_PIDS),
48
        CGROUP_MASK_BPF_FIREWALL = CGROUP_CONTROLLER_TO_MASK(CGROUP_CONTROLLER_BPF_FIREWALL),
49
        CGROUP_MASK_BPF_DEVICES = CGROUP_CONTROLLER_TO_MASK(CGROUP_CONTROLLER_BPF_DEVICES),
50
        CGROUP_MASK_BPF_FOREIGN = CGROUP_CONTROLLER_TO_MASK(CGROUP_CONTROLLER_BPF_FOREIGN),
51
        CGROUP_MASK_BPF_SOCKET_BIND = CGROUP_CONTROLLER_TO_MASK(CGROUP_CONTROLLER_BPF_SOCKET_BIND),
52
        CGROUP_MASK_BPF_RESTRICT_NETWORK_INTERFACES = CGROUP_CONTROLLER_TO_MASK(CGROUP_CONTROLLER_BPF_RESTRICT_NETWORK_INTERFACES),
53

54
        /* All real cgroup v1 controllers */
55
        CGROUP_MASK_V1 = CGROUP_MASK_CPU|CGROUP_MASK_CPUACCT|CGROUP_MASK_BLKIO|CGROUP_MASK_MEMORY|CGROUP_MASK_DEVICES|CGROUP_MASK_PIDS,
56

57
        /* All real cgroup v2 controllers */
58
        CGROUP_MASK_V2 = CGROUP_MASK_CPU|CGROUP_MASK_CPUSET|CGROUP_MASK_IO|CGROUP_MASK_MEMORY|CGROUP_MASK_PIDS,
59

60
        /* All controllers we want to delegate in case of Delegate=yes. Which are pretty much the v2 controllers only, as delegation on v1 is not safe, and bpf stuff isn't a real controller */
61
        CGROUP_MASK_DELEGATE = CGROUP_MASK_V2,
62

63
        /* All cgroup v2 BPF pseudo-controllers */
64
        CGROUP_MASK_BPF = CGROUP_MASK_BPF_FIREWALL|CGROUP_MASK_BPF_DEVICES|CGROUP_MASK_BPF_FOREIGN|CGROUP_MASK_BPF_SOCKET_BIND|CGROUP_MASK_BPF_RESTRICT_NETWORK_INTERFACES,
65

66
        _CGROUP_MASK_ALL = CGROUP_CONTROLLER_TO_MASK(_CGROUP_CONTROLLER_MAX) - 1,
67
} CGroupMask;
68

69
/* Special values for all weight knobs on unified hierarchy */
70
#define CGROUP_WEIGHT_INVALID UINT64_MAX
71
#define CGROUP_WEIGHT_IDLE UINT64_C(0)
72
#define CGROUP_WEIGHT_MIN UINT64_C(1)
73
#define CGROUP_WEIGHT_MAX UINT64_C(10000)
74
#define CGROUP_WEIGHT_DEFAULT UINT64_C(100)
75

76
#define CGROUP_LIMIT_MIN UINT64_C(0)
77
#define CGROUP_LIMIT_MAX UINT64_MAX
78

79
static inline bool CGROUP_WEIGHT_IS_OK(uint64_t x) {
×
80
        return
×
81
            x == CGROUP_WEIGHT_INVALID ||
×
82
            (x >= CGROUP_WEIGHT_MIN && x <= CGROUP_WEIGHT_MAX);
×
83
}
84

85
/* IO limits on unified hierarchy */
86
typedef enum CGroupIOLimitType {
87
        CGROUP_IO_RBPS_MAX,
88
        CGROUP_IO_WBPS_MAX,
89
        CGROUP_IO_RIOPS_MAX,
90
        CGROUP_IO_WIOPS_MAX,
91

92
        _CGROUP_IO_LIMIT_TYPE_MAX,
93
        _CGROUP_IO_LIMIT_TYPE_INVALID = -EINVAL,
94
} CGroupIOLimitType;
95

96
extern const uint64_t cgroup_io_limit_defaults[_CGROUP_IO_LIMIT_TYPE_MAX];
97

98
const char* cgroup_io_limit_type_to_string(CGroupIOLimitType t) _const_;
99
CGroupIOLimitType cgroup_io_limit_type_from_string(const char *s) _pure_;
100
void cgroup_io_limits_list(void);
101

102
/* Special values for the io.bfq.weight attribute */
103
#define CGROUP_BFQ_WEIGHT_INVALID UINT64_MAX
104
#define CGROUP_BFQ_WEIGHT_MIN UINT64_C(1)
105
#define CGROUP_BFQ_WEIGHT_MAX UINT64_C(1000)
106
#define CGROUP_BFQ_WEIGHT_DEFAULT UINT64_C(100)
107

108
/* Convert the normal io.weight value to io.bfq.weight */
109
static inline uint64_t BFQ_WEIGHT(uint64_t io_weight) {
×
110
        return
×
111
            io_weight <= CGROUP_WEIGHT_DEFAULT ?
112
            CGROUP_BFQ_WEIGHT_DEFAULT - (CGROUP_WEIGHT_DEFAULT - io_weight) * (CGROUP_BFQ_WEIGHT_DEFAULT - CGROUP_BFQ_WEIGHT_MIN) / (CGROUP_WEIGHT_DEFAULT - CGROUP_WEIGHT_MIN) :
×
113
            CGROUP_BFQ_WEIGHT_DEFAULT + (io_weight - CGROUP_WEIGHT_DEFAULT) * (CGROUP_BFQ_WEIGHT_MAX - CGROUP_BFQ_WEIGHT_DEFAULT) / (CGROUP_WEIGHT_MAX - CGROUP_WEIGHT_DEFAULT);
×
114
}
115

116
typedef enum CGroupUnified {
117
        CGROUP_UNIFIED_UNKNOWN = -1,
118
        CGROUP_UNIFIED_NONE = 0,        /* Both systemd and controllers on legacy */
119
        CGROUP_UNIFIED_SYSTEMD = 1,     /* Only systemd on unified */
120
        CGROUP_UNIFIED_ALL = 2,         /* Both systemd and controllers on unified */
121
} CGroupUnified;
122

123
/*
124
 * General rules:
125
 *
126
 * We accept named hierarchies in the syntax "foo" and "name=foo".
127
 *
128
 * We expect that named hierarchies do not conflict in name with a
129
 * kernel hierarchy, modulo the "name=" prefix.
130
 *
131
 * We always generate "normalized" controller names, i.e. without the
132
 * "name=" prefix.
133
 *
134
 * We require absolute cgroup paths. When returning, we will always
135
 * generate paths with multiple adjacent / removed.
136
 */
137

138
int cg_path_open(const char *controller, const char *path);
139
int cg_cgroupid_open(int cgroupfs_fd, uint64_t id);
140

141
int cg_path_from_cgroupid(int cgroupfs_fd, uint64_t id, char **ret);
142
int cg_get_cgroupid_at(int dfd, const char *path, uint64_t *ret);
143
static inline int cg_path_get_cgroupid(const char *path, uint64_t *ret) {
4,026✔
144
        return cg_get_cgroupid_at(AT_FDCWD, path, ret);
4,026✔
145
}
146
static inline int cg_fd_get_cgroupid(int fd, uint64_t *ret) {
7✔
147
        return cg_get_cgroupid_at(fd, NULL, ret);
7✔
148
}
149

150
typedef enum CGroupFlags {
151
        CGROUP_SIGCONT            = 1 << 0,
152
        CGROUP_IGNORE_SELF        = 1 << 1,
153
        CGROUP_DONT_SKIP_UNMAPPED = 1 << 2,
154
} CGroupFlags;
155

156
int cg_enumerate_processes(const char *controller, const char *path, FILE **ret);
157
int cg_read_pid(FILE *f, pid_t *ret, CGroupFlags flags);
158
int cg_read_pidref(FILE *f, PidRef *ret, CGroupFlags flags);
159

160
int cg_enumerate_subgroups(const char *controller, const char *path, DIR **ret);
161
int cg_read_subgroup(DIR *d, char **ret);
162

163
typedef int (*cg_kill_log_func_t)(const PidRef *pid, int sig, void *userdata);
164

165
int cg_kill(const char *path, int sig, CGroupFlags flags, Set *killed_pids, cg_kill_log_func_t log_kill, void *userdata);
166
int cg_kill_kernel_sigkill(const char *path);
167
int cg_kill_recursive(const char *path, int sig, CGroupFlags flags, Set *killed_pids, cg_kill_log_func_t log_kill, void *userdata);
168

169
int cg_split_spec(const char *spec, char **ret_controller, char **ret_path);
170
int cg_mangle_path(const char *path, char **ret);
171

172
int cg_get_path(const char *controller, const char *path, const char *suffix, char **ret);
173
int cg_get_path_and_check(const char *controller, const char *path, const char *suffix, char **ret);
174

175
int cg_pid_get_path(const char *controller, pid_t pid, char **ret);
176
int cg_pidref_get_path(const char *controller, const PidRef *pidref, char **ret);
177

178
int cg_is_threaded(const char *path);
179

180
int cg_is_delegated(const char *path);
181
int cg_is_delegated_fd(int fd);
182

183
int cg_has_coredump_receive(const char *path);
184

185
int cg_set_attribute(const char *controller, const char *path, const char *attribute, const char *value);
186
int cg_get_attribute(const char *controller, const char *path, const char *attribute, char **ret);
187
int cg_get_keyed_attribute(const char *controller, const char *path, const char *attribute, char * const *keys, char **values);
188

189
int cg_get_attribute_as_uint64(const char *controller, const char *path, const char *attribute, uint64_t *ret);
190
int cg_get_attribute_as_bool(const char *controller, const char *path, const char *attribute);
191

192
int cg_get_owner(const char *path, uid_t *ret_uid);
193

194
int cg_set_xattr(const char *path, const char *name, const void *value, size_t size, int flags);
195
int cg_get_xattr(const char *path, const char *name, char **ret, size_t *ret_size);
196
/* Returns negative on error, and 0 or 1 on success for the bool value */
197
int cg_get_xattr_bool(const char *path, const char *name);
198
int cg_remove_xattr(const char *path, const char *name);
199

200
int cg_is_empty(const char *controller, const char *path);
201

202
int cg_get_root_path(char **path);
203

204
int cg_path_get_session(const char *path, char **ret_session);
205
int cg_path_get_owner_uid(const char *path, uid_t *ret_uid);
206
int cg_path_get_unit(const char *path, char **ret_unit);
207
int cg_path_get_unit_path(const char *path, char **ret_unit);
208
int cg_path_get_user_unit(const char *path, char **ret_unit);
209
int cg_path_get_machine_name(const char *path, char **ret_machine);
210
int cg_path_get_slice(const char *path, char **ret_slice);
211
int cg_path_get_user_slice(const char *path, char **ret_slice);
212

213
int cg_shift_path(const char *cgroup, const char *cached_root, const char **ret_shifted);
214
int cg_pid_get_path_shifted(pid_t pid, const char *cached_root, char **ret_cgroup);
215

216
int cg_pid_get_session(pid_t pid, char **ret_session);
217
int cg_pidref_get_session(const PidRef *pidref, char **ret);
218
int cg_pid_get_owner_uid(pid_t pid, uid_t *ret_uid);
219
int cg_pidref_get_owner_uid(const PidRef *pidref, uid_t *ret);
220
int cg_pid_get_unit(pid_t pid, char **ret_unit);
221
int cg_pidref_get_unit(const PidRef *pidref, char **ret);
222
int cg_pid_get_user_unit(pid_t pid, char **ret_unit);
223
int cg_pid_get_machine_name(pid_t pid, char **ret_machine);
224
int cg_pid_get_slice(pid_t pid, char **ret_slice);
225
int cg_pid_get_user_slice(pid_t pid, char **ret_slice);
226

227
int cg_path_decode_unit(const char *cgroup, char **ret_unit);
228

229
bool cg_needs_escape(const char *p);
230
int cg_escape(const char *p, char **ret);
231
char* cg_unescape(const char *p) _pure_;
232

233
bool cg_controller_is_valid(const char *p);
234

235
int cg_slice_to_path(const char *unit, char **ret);
236

237
int cg_mask_supported(CGroupMask *ret);
238
int cg_mask_supported_subtree(const char *root, CGroupMask *ret);
239
int cg_mask_from_string(const char *s, CGroupMask *ret);
240
int cg_mask_to_string(CGroupMask mask, char **ret);
241

242
bool cg_kill_supported(void);
243

244
int cg_all_unified(void);
245
int cg_hybrid_unified(void);
246
int cg_unified_controller(const char *controller);
247
int cg_unified_cached(bool flush);
248
static inline int cg_unified(void) {
4✔
249
        return cg_unified_cached(true);
4✔
250
}
251

252
const char* cgroup_controller_to_string(CGroupController c) _const_;
253
CGroupController cgroup_controller_from_string(const char *s) _pure_;
254

255
typedef enum ManagedOOMMode {
256
        MANAGED_OOM_AUTO,
257
        MANAGED_OOM_KILL,
258
        _MANAGED_OOM_MODE_MAX,
259
        _MANAGED_OOM_MODE_INVALID = -EINVAL,
260
} ManagedOOMMode;
261

262
const char* managed_oom_mode_to_string(ManagedOOMMode m) _const_;
263
ManagedOOMMode managed_oom_mode_from_string(const char *s) _pure_;
264

265
typedef enum ManagedOOMPreference {
266
        MANAGED_OOM_PREFERENCE_NONE = 0,
267
        MANAGED_OOM_PREFERENCE_AVOID = 1,
268
        MANAGED_OOM_PREFERENCE_OMIT = 2,
269
        _MANAGED_OOM_PREFERENCE_MAX,
270
        _MANAGED_OOM_PREFERENCE_INVALID = -EINVAL,
271
} ManagedOOMPreference;
272

273
const char* managed_oom_preference_to_string(ManagedOOMPreference a) _const_;
274
ManagedOOMPreference managed_oom_preference_from_string(const char *s) _pure_;
STATUS · Troubleshooting · Open an Issue · Sales · Support · CAREERS · ENTERPRISE · START FREE · SCHEDULE DEMO
ANNOUNCEMENTS · TWITTER · TOS & SLA · Supported CI Services · What's a CI service? · Automated Testing

© 2026 Coveralls, Inc