90fcbe81-971e-4d3f-858a-e0ec8e932fa6
97%
main: 97%

Ran 01 Jul 2025 05:46PM UTC

Jobs 4

Files 142

Run time 1min

Badge

Embed ▾

Committed 01 Jul 2025 05:37PM UTC coverage: 97.424%. Remained the same

Build # 90fcbe81-971e-4d3f-858a-e0ec8e932fa6

Build Type

Pull #2468

circleci

Committed by

mark-dce

Commit Message

Fix redlock deprecation warnings

**ISSUE**
After the `Redis.current` fix, we are now seeing significant numbers
of deprecations warnings like:
```
Passing 'call' command to redis as is; blind passthrough has been
  deprecated and will be removed in redis-namespace 2.0
  (at /Users/mark/.rbenv/versions/2.7.4/lib/ruby/gems/2.7.0/gems/
   redlock-2.0.6/lib/redlock/client.rb:214:in `block (2 levels) in unlock')
```

**DIAGNOSIS**
We were passing a RedisNamespace object to Redlock instead of a
plain Redis connection specifier. RedisNamespace was complaining
any time an admin (not-namespace-able) command was received.

**RESOLUTION**
Pass a Redis URI to RedLock instead of a RedisNamespace object.

Pull Request Pull Request #2468: Fix redlock deprecation warnings

Run Details

2 of 2 new or added lines in 1 file covered. (100.0%)

122 existing lines in 26 files now uncovered.

2837 of 2912 relevant lines covered (97.42%)

52.1 hits per line

Uncovered Existing Lines

Lines	Coverage	∆	File
1	80.0	-20.0%	app/controllers/omniauth_controller.rb
1	86.36	-4.55%	app/models/committee_member.rb
1	85.71	-14.29%	app/models/registrar_feed.rb
1	98.48	-1.52%	app/models/solr_document.rb
1	87.5	-12.5%	app/presenters/etd_file_set_presenter.rb
1	85.71	-14.29%	app/services/admin_set_chooser.rb
1	92.86	-3.57%	app/services/hyrax/workflow/laevigata_notification.rb
1	88.89	-11.11%	app/services/hyrax/workflow/virus_encountered_notification.rb
1	83.33	-16.67%	config/exception_middleware.rb
2	83.33	-16.67%	app/actors/primary_file_title_actor.rb
2	96.08	-3.92%	app/forms/hyrax/etd_form.rb
2	92.31	-7.69%	app/forms/single_valued_form.rb
2	81.82	-18.18%	app/services/hyrax/workflow/hidden_notification.rb
3	40.0	-60.0%	app/constraints/user_is_admin.rb
3	66.67	-33.33%	app/services/hyrax/workflow/pending_review_notification.rb
3	66.67	-33.33%	app/services/hyrax/workflow/reviewed_notification.rb
3	66.67	-33.33%	app/services/hyrax/workflow/unhidden_notification.rb
3	96.38	-2.17%	lib/workflow_setup.rb
4	87.5	-12.5%	app/actors/hyrax/actors/default_admin_set_actor.rb
6	86.88	-3.75%	app/models/proquest_behaviors.rb
6	87.37	-6.32%	app/presenters/etd_presenter.rb
10	71.11	-22.22%	app/jobs/attach_files_to_work_job.rb
11	40.74	-40.74%	app/models/schools/school.rb
12	42.31	-46.15%	app/services/hyrax/laevigata_authority_service.rb
17	59.52	-40.48%	app/models/user.rb
24	40.74	-44.44%	app/actors/hyrax/actors/create_with_remote_files_actor.rb

Jobs

ID	Job ID	Ran	Files	Coverage
1	90fcbe81-971e-4d3f-858a-e0ec8e932fa6.1	01 Jul 2025 05:46PM UTC	115	90.47
2	90fcbe81-971e-4d3f-858a-e0ec8e932fa6.2	01 Jul 2025 05:47PM UTC	126	74.52
3	90fcbe81-971e-4d3f-858a-e0ec8e932fa6.3	01 Jul 2025 05:48PM UTC	122	86.28
4	90fcbe81-971e-4d3f-858a-e0ec8e932fa6.4	01 Jul 2025 05:48PM UTC	126	83.56

curationexperts / laevigata / 90fcbe81-971e-4d3f-858a-e0ec8e932fa6
97%
main: 97%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Uncovered Existing Lines

Jobs

Source Files on build 90fcbe81-971e-4d3f-858a-e0ec8e932fa6

curationexperts / laevigata / 90fcbe81-971e-4d3f-858a-e0ec8e932fa6 97% main: 97%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Uncovered Existing Lines

Jobs

Source Files on build 90fcbe81-971e-4d3f-858a-e0ec8e932fa6

curationexperts / laevigata / 90fcbe81-971e-4d3f-858a-e0ec8e932fa6
97%
main: 97%

README BADGES
x