90fcbe81-971e-4d3f-858a-e0ec8e932fa6

Committed 01 Jul 2025 05:37PM UTC coverage: 97.424%. Remained the same

Build # 90fcbe81-971e-4d3f-858a-e0ec8e932fa6

Build Type

Pull #2468

circleci

Committed by

mark-dce

Commit Message

Fix redlock deprecation warnings

**ISSUE**
After the `Redis.current` fix, we are now seeing significant numbers
of deprecations warnings like:
```
Passing 'call' command to redis as is; blind passthrough has been
  deprecated and will be removed in redis-namespace 2.0
  (at /Users/mark/.rbenv/versions/2.7.4/lib/ruby/gems/2.7.0/gems/
   redlock-2.0.6/lib/redlock/client.rb:214:in `block (2 levels) in unlock')
```

**DIAGNOSIS**
We were passing a RedisNamespace object to Redlock instead of a
plain Redis connection specifier. RedisNamespace was complaining
any time an admin (not-namespace-able) command was received.

**RESOLUTION**
Pass a Redis URI to RedLock instead of a RedisNamespace object.

Pull Request Pull Request #2468: Fix redlock deprecation warnings

Run Details

2 of 2 new or added lines in 1 file covered. (100.0%)

122 existing lines in 26 files now uncovered.

2837 of 2912 relevant lines covered (97.42%)

52.1 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

100.0

/app/controllers/omniauth_controller.rb

1	class OmniauthController < Devise::SessionsController	2✔
2	def new	2✔
3	# Rails.logger.debug "SessionsController#new: request.referer = #{request.referer}"
4	if Rails.env.production?	3✔
UNCOV 5	redirect_to user_shibboleth_omniauth_authorize_path	1✔
6	else
7	super	2✔
8	end
9	end
10	end

curationexperts / laevigata / 90fcbe81-971e-4d3f-858a-e0ec8e932fa6

Source File Press 'n' to go to next uncovered line, 'b' for previous

Source File
Press 'n' to go to next uncovered line, 'b' for previous