agama-project / agama / 15971963785

74%

Build Type

push

github

Committed by web-flow

Commit Message

 ipmitool invocation: do not write spurious % percent sign (#2525)

## Problem

Noticed a suspicious character in `ipmitool` input during team review of
#2490.
The tool may be permissive and work just fine, but let's remove it just
to be sure.

- https://trello.com/c/F1y5U83s
- https://jira.suse.com/browse/PED-12285

## Solution

- remove `%`
- format the number in hex
- add comments about the magic numbers

## Testing

Not yet :cry: , just ran `irb` to check that `31.to_s(16)` returns
`"1f"`.

Looked really hard at the change and hope that it improves the result of
calling the command.

Will use an IPMI emulator as hinted in jira

## Screenshots

No

## Documentation

Developer: added specification links
User: no

Run Details

1884 of 3403 branches covered (55.36%)

Branch coverage included in aggregate %.

0 of 1 new or added line in 1 file covered. (0.0%)

1 existing line in 1 file now uncovered.

23674 of 36281 relevant lines covered (65.25%)

47.19 hits per line