JuliaLang / julia / #38116

77%

Build Type

push

local

Committed by web-flow

Commit Message

bpart: Properly track methods with invalidated source after require_world (#58830)

There are three categories of methods we need to worry about during
staticdata validation:
1. New methods added to existing generic functions
2. New methods added to new generic functions
3. Existing methods that now have new CodeInstances

In each of these cases, we need to check whether any of the implicit
binding edges from the method's source was invalidated. Currently, we
handle this for 1 and 2 by explicitly scanning the method on load.
However, we were not tracking it for case 3. Fix that by using an extra
bit in did_scan_method that gets set when we see an existing method
getting invalidated, so we know that we need to drop the corresponding
CodeInstances during load.

Fixes #58346

Run Details

12 of 23 new or added lines in 3 files covered. (52.17%)

1 existing line in 1 file now uncovered.

12869 of 50093 relevant lines covered (25.69%)

683921.29 hits per line