kobotoolbox / kpi / 15883751045

81%

master: 76%

push

github

fix(organizations): always use username for organization slug DEV-626 (#5864)

### 📣 Summary
Fixes a bug wherein if too many users had the same organization name in
their extra details, eventually some would not be able to log in.


### 💭 Notes
Always use the user's username to generate the organization slug because
it is guaranteed to be unique, so there is no risk of `RuntimeError: max
slug attempts for <name> exceeded (100)`


### 👀 Preview steps

1. Open a Django shell
2. Create 110 users with `'organization': 'same_name'` in their
`extra_details.data` dictionary. It will be easiest if you use some
common prefix for the username
3. Delete any organizations that were created
(`Organization.objects.filter(name__startswith=<username_prefix>.delete()`)
4. Run:
```
for user in User.objects.filter(extra_details__data__organization='same_name'):
      print(user.organization.slug)
```
5. 🔴 [on release] After the first hundred users you will get
`RuntimeError: max slug attempts for <name> exceeded (100)`
6. 🟢 [on PR] No error and the organization slugs will match the
usernames

6123 of 9716 branches covered (63.02%)

23154 of 28692 relevant lines covered (80.7%)

0.81 hits per line