15867586914
83%

Ran 25 Jun 2025 05:44AM UTC

Jobs 1

Files 58

Run time 1min

Badge

Embed ▾

Committed 24 Jun 2025 11:19AM UTC coverage: 85.682% (+0.02%) from 85.661%

Build # 15867586914

Build Type

push

github

Committed by

web-flow

Commit Message

[FIXED] Health check only does reporting (#7001)

The health check could still reset/restart stream and consumer Raft
nodes. However, if a new Raft node instance is assigned to the
stream/consumer assignment, but this is not yet reflected in the
stream/consumer, then the new Raft node's state would be fully deleted.
This is possible because the assignment's Raft node is updated under the
JS lock, but the stream/consumer nodes aren't, resulting in many
potential race conditions for the health check to do the wrong thing.

The health check must only do reporting and not try to fix anything, it
simply can't guarantee both the assignment and stream/consumer nodes are
not stale.

When the logs show `Detected stream/consumer cluster node skew` once,
there's nothing to worry about. It was simply a temporary condition that
resolved itself. If it's logged for every health check, something went
wrong. The health check must not attempt to fix this, we should fix the
underlying bug if this is observed.

Signed-off-by: Maurice van Veen <github@mauricevanveen.com>

Run Details

70201 of 81932 relevant lines covered (85.68%)

379804.54 hits per line

Uncovered Existing Lines

Lines	Coverage	∆	File
2	86.5	-0.06%	src/github.com/nats-io/nats-server/server/accounts.go
2	83.37	0.05%	src/github.com/nats-io/nats-server/server/filestore.go
2	94.2	-0.08%	src/github.com/nats-io/nats-server/server/gateway.go
2	82.76	0.0%	src/github.com/nats-io/nats-server/server/jetstream.go
2	94.52	-0.06%	src/github.com/nats-io/nats-server/server/server.go
4	52.92	-0.32%	src/github.com/nats-io/nats-server/server/jetstream_errors_generated.go
6	86.22	-0.19%	src/github.com/nats-io/nats-server/server/events.go
7	81.26	0.02%	src/github.com/nats-io/nats-server/server/opts.go
7	85.35	-0.15%	src/github.com/nats-io/nats-server/server/stream.go
8	94.94	-0.16%	src/github.com/nats-io/nats-server/server/client.go
11	87.84	0.05%	src/github.com/nats-io/nats-server/server/consumer.go
11	73.33	-0.14%	src/github.com/nats-io/nats-server/server/jetstream_api.go
14	86.18	0.45%	src/github.com/nats-io/nats-server/server/memstore.go
19	85.63	0.0%	src/github.com/nats-io/nats-server/server/raft.go
951	81.7	0.38%	src/github.com/nats-io/nats-server/server/jetstream_cluster.go

Jobs

ID	Job ID	Ran	Files	Coverage
1	15867586914.1	25 Jun 2025 05:44AM UTC	58	85.68	GitHub Action Run

nats-io / nats-server / 15867586914
83%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Uncovered Existing Lines

Jobs

Source Files on build 15867586914

nats-io / nats-server / 15867586914 83%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Uncovered Existing Lines

Jobs

Source Files on build 15867586914

nats-io / nats-server / 15867586914
83%

README BADGES
x