agama-project / agama / 15737822052

74%

Build Type

push

github

Committed by web-flow

Commit Message

Disable local installation repositories (bsc#1243064) (#2491)

## Problem

- When using a local installation repository (e.g. Full DVD) then this
repository is removed from the system
- It should behave like in SLE15 which keeps the installation
repository, just disables it. After enabling it manually it can be used
for installing additional packages.

## Solution

- Disable local repositories instead of removing them

## Notes

- Because we keep the Full installation repository in the system it
should have some meaningful name and alias. And because the packages are
fixed the autorefresh should be disabled.
- This required extending the API to allow specifying required data.

## DVD

- For DVDs during installation the device name is included in the URL to
ensure the correct repository is used.
- In theory there might be multiple DVD drives in the system and the
other drive might contain a different version of the product or a
completely different product. This ensures libzypp uses the correct
drive.
- After installation the device is removed from URL, this allows
inserting the installation medium into a different drive without a
failure. Libzypp verifies that the correct medium is inserted by
checking the `/media.1/media` content with the file saved in the cache.

## Hard disk or USB flash disk

- For these media it uses the `/dev/disk/by-id` device name. That should
be more specific and should avoid problems with using incorrect media.
- This is important for USB flash disks for which the device name might
change in the installed system. The installation flash disk might become
`/dev/sdc` instead of `/dev/sdb` if you attach some different USB flash
disk before it.

## Testing

- Updated unit test
- Tested manually

## Screenshots

- In all cases after enabling the repository manually it was possible to
install additional package from the original installation medium.

### Installation from DVD

- When installing from the DVD the repository URL is mo... (continued)

Run Details

1840 of 3390 branches covered (54.28%)

Branch coverage included in aggregate %.

16 of 32 new or added lines in 3 files covered. (50.0%)

1 existing line in 1 file now uncovered.

21647 of 32813 relevant lines covered (65.97%)

51.22 hits per line