tari-project / tari / 15705904978
62%

DEFAULT BRANCH: development
Ran
Jobs 1
Files 690
Run time 11min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
coverage: 72.176% (+0.6%) from 71.528%
15705904978

push

github

web-flow 
fix: fix scanner service when connectivity offline (#7223)

Description
---
Fixed the scanner service when connectivity is offline - the
connectivity status will now be queried to start scanning, instead of
relying on a based node change to initiate the process. The logical
error was introduced in a recent PR.

Motivation and Context
---
Unit test `async fn test_utxo_scanner_one_sided_payments()` failed due
to logic implementation error.

How Has This Been Tested?
---
Unit test `async fn test_utxo_scanner_one_sided_payments()` pass.

What process can a PR reviewer use to test or verify this change?
---
Code review.

<!-- Checklist -->
<!-- 1. Is the title of your PR in the form that would make nice release
notes? The title, excluding the conventional commit
tag, will be included exactly as is in the CHANGELOG, so please think
about it carefully. -->


Breaking Changes
---

- [x] None
- [ ] Requires data directory on base node to be deleted
- [ ] Requires hard fork
- [ ] Other - Please specify

<!-- Does this include a breaking change? If so, include this line as a
footer -->
<!-- BREAKING CHANGE: Description what the user should do, e.g. delete a
database, resync the chain -->


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit

- **Refactor**
- Improved internal logic for connectivity checks and status handling in
the UTXO scanning service.
- Converted certain recovery mode methods from asynchronous to
synchronous for more efficient execution.
- Simplified transaction status filtering logic for better performance.

- **Tests**
- Enhanced test setup and logging for better debugging and reliability.

No changes to user-facing features or functionality.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->

13 of 19 new or added lines in 2 files covered. (68.42%)

35 existing lines in 12 files now uncovered.

81882 of 113448 relevant lines covered (72.18%)

243173.99 hits per line

New Missed Lines in Diff

Lines Coverage ∆ File
6
70.41
 29.55% base_layer/wallet/src/utxo_scanner_service/service.rs

Uncovered Existing Lines

Lines Coverage ∆ File
1
22.35
 -1.18% base_layer/core/src/chain_storage/error.rs
1
88.48
 0.0% base_layer/core/src/chain_storage/lmdb_db/validator_node_store.rs
1
83.5
 -0.49% base_layer/core/src/transactions/transaction_key_manager/storage/sqlite_db/mod.rs
1
74.06
 0.0% base_layer/wallet/src/output_manager_service/storage/sqlite_db/mod.rs
1
83.64
 -0.04% base_layer/wallet/src/transaction_service/storage/sqlite_db.rs
1
69.53
 -0.43% comms/core/src/protocol/messaging/protocol.rs
2
64.66
 0.13% comms/dht/src/connectivity/mod.rs
2
95.87
 -0.38% comms/dht/src/outbound/broadcast.rs
3
60.62
 -1.33% comms/core/src/connectivity/requester.rs
4
67.18
 4.58% base_layer/core/src/chain_storage/lmdb_db/lmdb_db.rs
8
53.08
 1.76% base_layer/core/src/base_node/state_machine_service/states/listening.rs
10
78.99
 0.52% base_layer/core/src/test_helpers/blockchain.rs
Jobs
ID Job ID Ran Files Coverage
1 15705904978.1 690
72.18
 GitHub Action Run
Source Files on build 15705904978