tari-project / tari / 15641608958

62%

Build Type

push

github

Committed by web-flow

Commit Message

feat: integrated address support for Ledger (#7198)

## Description
This PR implements integrated address support for the
minotari_ledger_wallet application, allowing the Ledger hardware wallet
to handle addresses with embedded payment IDs. The implementation
supports variable-sized addresses from 67 bytes (standard dual
addresses) up to 323 bytes (with maximum 256-byte payment IDs).

### Key Changes:
- Updated address size constants and validation to support
variable-length addresses
- Modified address parsing functions to accept `&[u8]` instead of
fixed-size arrays
- Added payment ID extraction utility functions
- Enhanced transaction confirmation UI to display payment ID information
- Updated protocol data structures to include address size prefixes
- Added comprehensive test coverage and documentation

## Motivation and Context
Integrated addresses enable users to embed payment identifiers directly
within Tari addresses, improving payment tracking and reconciliation.
This feature is particularly important for exchanges, merchants, and
other services that need to associate payments with specific orders or
accounts. The Ledger wallet previously only supported fixed 67-byte dual
addresses, limiting its utility for these use cases.

## How Has This Been Tested?
- All existing unit tests pass without modification
- Added comprehensive new test suite covering:
  - Standard dual address compatibility (67 bytes)
  - Integrated addresses with various payment ID sizes
  - Boundary condition testing (min/max sizes)
  - Invalid address size rejection
  - Payment ID extraction and validation
- Compilation verified with `cargo check` and `cargo clippy`
- Both common and comms modules tested successfully

## What process can a PR reviewer use to test or verify this change?
1. **Compilation Check**: Run `cargo check` in
`applications/minotari_ledger_wallet/` to verify no compilation errors
2. **Unit Tests**: Run `cargo test` in both `common/` and `comms/`
subdire... (continued)

Run Details

97 of 118 new or added lines in 3 files covered. (82.2%)

643 existing lines in 27 files now uncovered.

81159 of 113465 relevant lines covered (71.53%)

564889.43 hits per line