agama-project / agama / 15709361115

74%

push

github

fix: make sure queries are sync (#2479)

## Problem

Here is a proposal to solve
[bsc#1243276](https://bugzilla.suse.com/show_bug.cgi?id=1243276) and
other synchronization problems. It needs to be tested more extensively.

We have detected that the web UI can get into the following scenario:

1. The web UI tries to connect to the WebSocket.
2. The web UI asks for the selected product. It caches the response.
3. The product gets selected, for instance, loading a profile.
4. The server emits the signal `ProductSelected`.
5. **The WebSocket connection is finally established.**

As you can see, there is a chance that Agama misses the signal (step 4).
If the WebSocket connections happens before (which is the normal case),
everything should work.

## Solution

* Do not mount the `App` component until the `WebSocket` is ready.
* If the connection is lost, `App` is umounted and it has the chance to
clean-up the queries.

## Tasks

- [x] Fix the tests.
- [x] Build an ISO to test the change. Testing images are
[here](https://download.opensuse.org/repositories/systemsmanagement:/Agama:/branches:/sync-queries/images/iso).

1840 of 3390 branches covered (54.28%)

Branch coverage included in aggregate %.

39 of 42 new or added lines in 6 files covered. (92.86%)

21618 of 32768 relevant lines covered (65.97%)

51.29 hits per line