agama-project / agama / 15683799307

74%

Build Type

push

github

Committed by web-flow

Commit Message

Initial support for sorting storage devices during the search (#2474)

## Problem

The results of the `search` section in the description of `drives`,
`partitions` and `mdRaids` are always sorted by name. Making it very
hard to specify something like "the two biggest disks".

## Solution

This implements support for implementing such searches with the syntax
shown in the following examples:

```json
{
  "search": {
    "sort": { "size": "desc" },
    "max": 2
  }
}
```

Several criteria can be specified to resolve ties.

```json
{
  "search": {
    "sort": [
        { "size": "desc" },
        "name"
    ],
    "max": 2
  }
}
```

And, of course, all that can be combined with a condition to filter out
devices before sorting.

```json
{
  "search": {
    "condition": { "size": { "less": "1TiB" } },
    "sort": { "size": "desc" },
    "max": 2
  }
}
```

## Testing

- Added unit tests for the new parts
- Tested manually

Run Details

92 of 132 branches covered (69.7%)

Branch coverage included in aggregate %.

9 of 9 new or added lines in 2 files covered. (100.0%)

1 existing line in 1 file now uncovered.

11185 of 14508 relevant lines covered (77.1%)

52.06 hits per line