safe-global / safe-smart-account / 15635191896

94%

push

github

Updating dependencies and ZKSolc version (#986)

This pull request introduces several updates to dependencies,
configurations, and code formatting across multiple files. The changes
aim to enhance compatibility, improve code quality, and update tooling
versions. Below is a summary of the most important changes, categorized
by theme:

### Configuration Updates:
*
[`.prettierrc`](diffhunk://#diff-663ade211aae5ceecbb491a2efc43d5d2L7-R7):
Changed the Solidity parser from `"solidity-parse"` to `"slang"` for
better compatibility with updated tooling.
*
[`.solhint.json`](diffhunk://#diff-36bf985dc8d765c7796d0c4e3b124dd92L17-R17):
Disabled the `"imports-order"` rule to reduce warnings during linting.
*
[`hardhat.config.ts`](diffhunk://#diff-57cf5378f7d81770045dda9c5f95effe3L92-R96):
Updated ZK compiler settings to use version `1.5.15` and switched code
generation to `"yul"`. Added suppressed warnings for `"assemblycreate"`
and `"txorigin"`.

### Dependency Updates:
*
[`package.json`](diffhunk://#diff-<a class=hub.com/safe-global/safe-smart-account/commit/<a class="double-link" href="https://git"><a class=hub.com/safe-global/safe-smart-account/commit/7ae45ad102eab3b6d7e7896acd08c427a9b25b34">7ae45ad106470d7bc6507b6481575d519L62-R62):
Upgraded multiple development dependencies, including `@eslint/js`,
`dotenv`, `eslint`, and `prettier-plugin-solidity`, to their latest
versions for improved functionality and compatibility.
[[1]](diffhunk://#diff-7ae45ad102eab3b6d7e7896acd08c427a9b25b346470d7bc6507b6481575d519L62-R62)
[[2]](diffhunk://#diff-7ae45ad102eab3b6d7e7896acd08c427a9b25b346470d7bc6507b6481575d519L71-R95)
*
[`certora/requirements.txt`](diffhunk://#diff-ce14d669197b94b13a8905750cc25629aL1-R1):
Updated the `certora-cli` version from `7.26.0` to `7.29.2`.

### Code Enhancements:
*
[`contracts/Safe.sol`](diffhunk://#diff-587b494ea16e1163b26e39de24e9483deL131-R132):
Improved readability by restructuring the `getTransactionHash` call to
limit variable lifetime and preve... (continued)

327 of 368 branches covered (88.86%)

Branch coverage included in aggregate %.

1 of 1 new or added line in 1 file covered. (100.0%)

491 of 503 relevant lines covered (97.61%)

104.17 hits per line