Unleash / unleash / 15629245473

86%

master: 91%

Build Type

push

github

Committed by web-flow

Commit Message

fix: md5 is deprecated and fails FEDRAMP. Replace with sha256 (#10125)

#10121 points out that we're using md5 functions still. This PR updates
our migrations to no longer use md5 at all (so if you haven't run the
migrations, you won't get email hashes until you get to the included
migration with this PR). If you've already run the migrations, we'll
drop the existing `email_hash varchar(32)` column and replace it with a
`email_hash TEXT` column.

We're also replacing the md5 function with `encode(sha256(email),
'hex')`. encode has been supported since PG10, sha256 came with PG11.

Do we want an index on the email_hash? I wasn't sure, but if we want to
do lookup we probably should have an index on it (though not a unique
one)

Run Details

6887 of 6938 branches covered (99.26%)

9 of 31 new or added lines in 4 files covered. (29.03%)

3 existing lines in 2 files now uncovered.

64784 of 72737 relevant lines covered (89.07%)

423.32 hits per line