kobotoolbox / kpi / 15614945045

81%

master: 76%

push

github

chore(removingAttachments): remove feature flag TASK-1838 (#5824)

### 💭 Notes

After removing feature flag, the feauture is easliy accessible.

### 👀 Preview steps

Case A: testing steps for Submission Modal:
1. ℹ️ Have a project with `audio`, `file`, `image`, and `video` question
2. Make a submission that has responses to all the questions
- go to Project > Form and use "Open" button in the "Collect data"
section
3. Go to Project > Data > Table
4. Open submission ("eye" icon button)
5. 🟢 Notice that each question response has now "…" button on the right
side
- Using "Download" button (link) should work for each of question type
   - Using "Delete" button should do this for each question type:
      1. a success notification appears
      2. "…" modal is closed
      3. Data Table underneath modal fetches new data
      4. 🟢 Notice that deleted attachment now appear as deleted
6. 🟢 Notice that when attachment is deleted the "…" button is not
rendered

Case B: testing steps for Table Media Preview modal (`file`, `image`,
and `video` questions):
1. Go through steps 1-3 of Case A
2. 🟢 Notice in the table that cell now has a file name and an icon
button (previously it was just the file name for `file` and just icon
for the other two)
3. Open a modal (icon button in the cell)
4. 🟢 Notice in the modal that we now have "…" button in top right
instead of "Download" button
   - Using "Download" button (link) should work
   - Using "Delete" button should do this for each question type:
      1. a success notification appears
      2. "…" modal is closed
      3. Data Table fetches new data
      4. 🟢 Notice that deleted attachment now appear as deleted
5. 🟢 Notice that for `file` type the file name and mimetype are being
displayed as modal content

Case C: testing steps for NLP View:
1. Go through steps 1-3 of Case A
2. For `audio` question response use "Open" button
3. 🟢 Notice that in the right side the audio player now has "…" button
   - Using "Download" b... (continued)

6278 of 9941 branches covered (63.15%)

23949 of 29538 relevant lines covered (81.08%)

1.6 hits per line