agama-project / agama / 15589199245

74%

push

github

feat(web): add post-installation feedback (#2462)

## Problem

Currently, users receive no visual feedback after clicking either
"Reboot" or "Finish" on the installation completion page. This lack of
confirmation can lead to uncertainty about whether the intended action
has taken effect.

Reported in: https://bugzilla.suse.com/show_bug.cgi?id=1237410
(protected link)

## Solution

Display proper feedback to provide clear confirmation that the system
has either restarted or powered off. It also explicitly informs users
that installer is not longer available and the page can be safely
closed.

## Implementation notes

* The new path (`/installation/exit`) does not take Iguana into account,
as it has been agreed that Agama will no longer support it.

* Agama assumes the system reboot has been triggered successfully
without waiting for a response. Although it’s unlikely, there could be a
chance the response might not be received if the system begins rebooting
before the server sends it. This edge case still requires testing, but
for now, assuming the reboot will take effect is considered sufficient.

* Although initially considered, the reboot action does not explicitly
trigger a WebSocket disconnection. The connection will drop
automatically after the maximum number of reconnection attempts.
Importantly, it won’t fall back to either the `Loading` or `ServerError`
screens, since the post-installation views are not under the scope of
[internal `App.tsx`
routing](https://github.com/agama-project/agama/blob/abd855298/web/src/App.tsx#L55-L90).

* Unfortunately, it’s not possible to fully clear the browser history
stack to prevent users from navigating back to earlier installation
steps. Users are encouraged to close the installer upon completion. If
they do navigate back, they will likely encounter a `ServerError`
screen.

---

Related to https://trello.com/c/OJhG0Ovr/ (protected link)

92 of 132 branches covered (69.7%)

Branch coverage included in aggregate %.

11248 of 17981 relevant lines covered (62.55%)

41.87 hits per line