agama-project / agama / 15579666570

74%

Build Type

push

github

Committed by web-flow

Commit Message

feat(rust): improve user/root exported information (#2461)

## Problem

There are a few problems with the user and root settings that "agama
config show" generates.

1. It is not possible to get the root password (it is not exposed). See
[bsc#1235602](https://bugzilla.suse.com/show_bug.cgi?id=1235602).
2. The `user` section is exported even if a first user does not exist.
3. The `root` section is exported even if no authentication mechanism
has been defined.
4. The `hashed_password` key is exported even if the `root` only has an
SSH public key.

For instance, here's the output for a just started Agama instance:

```json
{
  "root": {},
  "user": {
    "fullName": "",
    "userName": "",
    "password": "",
    "hashedPassword": false
  }
}
```

## Solution

* Move the password settings to a single struct (`UserPassword`). The
`password` and the `hashedPassword` keys are always exported together.
* Do not export the `user` or `root` sections unless it is needed.

I decided to not make the changes at HTTP level because it would imply
adapting the web client too and we have more urgent things to work on.

## Testing

- *Updated the unit test*
- *Tested manually*

Run Details

92 of 132 branches covered (69.7%)

Branch coverage included in aggregate %.

0 of 39 new or added lines in 3 files covered. (0.0%)

1 existing line in 1 file now uncovered.

11235 of 17968 relevant lines covered (62.53%)

41.76 hits per line