Ouranosinc / xclim / 15495003246

92%

push

github

Add indexing to rolling indicators missing it (#2190)

<!--Please ensure the PR fulfills the following requirements! -->
<!-- If this is your first PR, make sure to add your details to the
AUTHORS.rst! -->
### Pull Request Checklist:
- [x] This PR addresses an already opened issue (for bug fixes /
features)
    - This PR fixes #2187 
- [x] Tests for the changes have been added (for bug fixes / features)
- [x] (If applicable) Documentation has been added / updated (for bug
fixes / features)
- [x] CHANGELOG.rst has been updated (with summary of main changes)
- [x] Link to issue (:issue:`number`) and pull request (:pull:`number`)
has been added

### What kind of change does this PR introduce?

* Adds the `**indexer` argument to a few indicators:
`max_n_day_precipitation_amount`, `max_pr_intensity` , `blowing_snow`.
These were the only "rolling" indicators missing it.
* Modifies `frost_days` to use the Indexing class instead of explicitly
handling indexing.
* At first I thought I add to add indexing to
`rain_on_frozen_grounds_days` only to realize it was already inheriting
it from its class. I generalized the `window` arg along the way.

These are "rolling" indicator as in the indice function does a `rolling`
operation and after which the indexing should happen. The indexing
feature is still missing the indicators that use `run_length`
constructs.


### Does this PR introduce a breaking change?
No.

### Other information:

11 of 11 new or added lines in 3 files covered. (100.0%)

7603 of 8235 relevant lines covered (92.33%)

8.09 hits per line