agama-project / agama / 15491140750

73%

Build Type

push

github

Committed by web-flow

Commit Message

Network persistent connections handling (#2402)

## Problem

With the current approach to network configuration in **SLE 16**, it is
possible that you end up with a system with no network at all.

Why? 
- We started copying all connections to the target system, but that
meant volatile connections were copied too and maybe the defaults are
not wanted in the target system so now only the persistent connections
are copied (the ones in **/etc/NetworkManager/system-connections**).
- Some products install NetworkManager-config-server package which
disables the auto-default DHCP probing on ethernet devices (see
https://github.com/agama-project/agama/pull/2279)
  - 

Agama should:

Warn the user.

Allow the user to get out of that situation at any time.

- https://bugzilla.suse.com/show_bug.cgi?id=1241969
-
https://trello.com/c/P6oGGmjH/4745-ui-handle-persistent-non-persistent-network-connections

## Solution
- The connections generated by nm-initrd-generator are moved instead of
copied to ensure them are seeing as permanent and not as in-memory only
by NM avoiding duplications and only the ones generated by
nm-initrd-generator will be copied (**TO BE FIXED:** ibft, nbft and
other kind of connections should be probably omitted).
- If no connection is going to be copied the user will be warned but by
now only in the networking section (there is no check of
**NetworkManager-config-server** package yet for showing the warn).
- The user can select which interfaces will be used for installation
only and switch between made them persistent or not.
- We have modified the way the connection is updated and we are now
using the Update2 and AddConnection2 methods using the
**NMSettingsAddConnection2Flags** and **NMSettingsUpdate2Flags** (see
https://networkmanager.dev/docs/api/latest/nm-dbus-types.html#NMSettingsConnectionFlags)


## Current Network State

In general,

**If an explicit network configuration through the kernel cmdline is
given then:**
1. Agama disables t... (continued)

Run Details

92 of 132 branches covered (69.7%)

Branch coverage included in aggregate %.

7 of 69 new or added lines in 8 files covered. (10.14%)

22 existing lines in 5 files now uncovered.

11130 of 17817 relevant lines covered (62.47%)

41.6 hits per line