kobotoolbox / kpi / 15490241932

81%

master: 76%

push

github

feat(projectHistoryLogs): change code to codename for partial perms D… (#5826)

Port of  DEV-218 (#5715)

### 📣 Summary
Change the key from 'code' to 'codename' for consistency when creating
PH logs for partial permission changes.


### 💭 Notes
The PH log table is huge and updating it is a pain, so this will only
change data going forward. Nothing on the front end relies on the
structure of the metadata field so the inconsistency shouldn't break
anything.


### 👀 Preview steps
1. ℹ️ have account and a project, and at least one other user
2. Go to Project > Settings > Sharing
3. Grant the second user permission to view only submissions from a
specific user
4. Go to `/api/v2/assets/<uid>/history`
5. 🟢 There should be a new `modify-user-permissions` PH log with 
```
                "permissions": {
                    "added": [
                        "view_asset",
                        "partial_submissions",
                        {
                            "filters": [
                                {
                                    "_submitted_by": "<user>"
                                }
                            ],
                            "codename": "view_submissions"
                        }
                    ],
                    "removed": [],
                    "username": "<user>"
                },
```
in the metadata

6085 of 9702 branches covered (62.72%)

1 of 1 new or added line in 1 file covered. (100.0%)

23076 of 28647 relevant lines covered (80.55%)

0.81 hits per line