agama-project / agama / 15469984059

73%

push

github

Fixed UI event handling (#2443)

## Problem

- The web UI is stuck and displays the spinner until the installation is
finished.
- https://bugzilla.suse.com/show_bug.cgi?id=1241208

## Details

- When the "status" query data was not obtained yet the
"InstallationPhaseChanged", "ProductChanged" and "IssuesChanged" web
socket events were ignored.
- This could possibly get the UI stuck when the loading screen was
displayed because of the `selectedProduct === undefined && isBusy`
condition.
- If the "ProductChanged" event was ignored in that case the loading
screen would be displayed until the installer is busy (i.e. until the
end of installation) because the selected product would not be
refreshed.

## Solution

- Handle those events even when the "status" is not defined.
- Add more logging to see more details if this fix is still not enough.

## Testing

- The bug happens only rarely and requires a very specific timing
between the web browser requests and the command line starting automatic
installation in background so I can not verify that it really fixes the
problem.

92 of 132 branches covered (69.7%)

Branch coverage included in aggregate %.

11130 of 17754 relevant lines covered (62.69%)

41.75 hits per line