rust-bitcoin / rust-bitcoin / 15447886098

83%

Build Type

push

github

Committed by apoelstra

Commit Message

Merge rust-bitcoin/rust-bitcoin#4534: Make `FeeRate` use MvB internally

<a class=hub.com/rust-bitcoin/rust-bitcoin/commit/56516757ad8874d8121dba468946546bb8fd7d4e">56516757a<a href="https://github.com/rust-bitcoin/rust-bitcoin/commit/a13ba99c11a1260e5129caca8dbe0a031d178a6f"> Add code comment to amount calculation (Tobin C. Harding)
<a class="double-link" href="https://github.com/rust-bitcoin/rust-bitcoin/commit/8cf1dc39b59cc6a6e98fdd50029e1b721536b66d">8cf1dc39b</a><a href="https://github.com/rust-bitcoin/rust-bitcoin/commit/a13ba99c11a1260e5129caca8dbe0a031d178a6f"> Fix incorrect code comment (Tobin C. Harding)
</a><a class="double-link" href="https://github.com/rust-bitcoin/rust-bitcoin/commit/7c186e6081fbc6af1b7907cc06e769e3b174be69">7c186e608</a><a href="https://github.com/rust-bitcoin/rust-bitcoin/commit/a13ba99c11a1260e5129caca8dbe0a031d178a6f"> Refactor fee functions (Tobin C. Harding)
</a><a class="double-link" href="https://github.com/rust-bitcoin/rust-bitcoin/commit/bf0776e3dd8f457ec5c4b368d05ffb09d2cda20d">bf0776e3d</a><a href="https://github.com/rust-bitcoin/rust-bitcoin/commit/a13ba99c11a1260e5129caca8dbe0a031d178a6f"> Remove panic using checked arithmetic (Tobin C. Harding)
</a><a class="double-link" href="https://github.com/rust-bitcoin/rust-bitcoin/commit/b65860067f7da1f4e665eb14d77adc6db9a3ba59">b65860067</a><a href="https://github.com/rust-bitcoin/rust-bitcoin/commit/a13ba99c11a1260e5129caca8dbe0a031d178a6f"> Make fee functions const (Tobin C. Harding)
</a><a class="double-link" href="https://github.com/rust-bitcoin/rust-bitcoin/commit/9b2fc021b21c44828e362b99fedf5654b2eeb785">9b2fc021b</a><a href="https://github.com/rust-bitcoin/rust-bitcoin/commit/a13ba99c11a1260e5129caca8dbe0a031d178a6f"> Improve rustdocs on FeeRate (Tobin C. Harding)
</a><a class="double-link" href="https://github.com/rust-bitcoin/rust-bitcoin/commit/1bd1e89458fe5ddca8c5c199bd3859a09640c636">1bd1e8945</a><a href="https://github.com/rust-bitcoin/rust-bitcoin/commit/a13ba99c11a1260e5129caca8dbe0a031d178a6f"> Re-introduce FeeRate encapsulate module (Tobin C. Harding)
</a><a class="double-link" href="https://github.com/rust-bitcoin/rust-bitcoin/commit/b27d8e581933aab5d7af5b034f9a422bc41c9bb5">b27d8e581 Change the internal representation of FeeRate (Tobin C. Harding)
2e0b88ba7 bitcoin: Fix dust 'fee' identifiers (Tobin C. Harding)
399bca531 Reduce the FeeRate::MAX value (Tobin C. Harding)
d174c06a4 Saturate to_fee to Amount::MAX (Tobin C. Harding)
64ac33754 Add missing argument docs (Tobin C. Harding)
fe0a448e7 Temporarily remove const from fee calc function (Tobin C. Harding)
b929022d5 Add floor/ceil versions of to_sat_per_kwu (Tobin C. Harding)
64098e457 Remove encapsulate module from fee rate (Tobin C. Harding)

Pull request description:

  The `FeeRate` is a bit entangled with amount and weight.  Also we have an off-by-one bug caused by rounding errors and the fact that we use kwu internally.

  We can get more precision in the fee rate by internally using per million virtual bytes.

  - Fix: #4516
  - Fix: #4497
  - Fix: #3806

ACKs for top commit:
  apoelstra:
    ACK 56516757ad8874d8121dba468946546bb8fd7d4e; successfully ran local tests

Tree-SHA512: 0c6e7e2c9a... (continued)

Coverage Stats

163 of 181 new or added lines in 7 files covered. (90.06%)

16 existing lines in 4 files now uncovered.

23533 of 27882 relevant lines covered (84.4%)

15909.73 hits per line