rust-bitcoin / rust-bitcoin / 15378089414

83%

push

github

Merge rust-bitcoin/rust-bitcoin#4565: Remove all `p2p` dependency from `network`

<a class=hub.com/rust-bitcoin/rust-bitcoin/commit/<a class="double-link" href="https://git"><a class=hub.com/rust-bitcoin/rust-bitcoin/commit/cbe04b00c67eab896b7ec0535194771ec36cb68f">cbe04b00c Remove all `p2p` dependency from `network` (rustaceanrob)

Pull request description:

  Motivated by moving the `p2p` module to its own crate. `TryFrom` and `From` are already implement for converting to and from `Network`/`Magic`. The methods related to `Magic` are removed from `Network`, as well as any reference to `p2p` in the documentation, as `bitcoin` would no longer depend on `p2p`.

  The deser roundtrip test are relocated to `p2p/mod.rs`

ACKs for top commit:
  tcharding:
    ACK cbe04b00c67eab896b7ec0535194771ec36cb68f
  apoelstra:
    ACK cbe04b00c67eab896b7ec0535194771ec36cb68f; successfully ran local tests

Tree-SHA512: ac3aa2eef7997111faba335cbaa5942af7d

28 of 28 new or added lines in 1 file covered. (100.0%)

23505 of 27845 relevant lines covered (84.41%)

15905.28 hits per line