agama-project / agama / 15416257219

73%

Build Type

push

github

Committed by web-flow

Commit Message

Send different NM dbus values depending on version (#2356)

## Problem

Agama doesn't detect and handle different NetworkManager versions. I
know that currently this isn't an issue for agama itself, however I
think it may become one in the future. Also for wicked2nm it represents
a problem because when it is run on Leap15, it tries to send values that
are not present due to the old NM version. See
https://github.com/openSUSE/wicked2nm/issues/24

## Solution

Parse NM version via the semver crate and then act accordingly when
populating dbus values. I haven't checked all the values and when they
were introduced, but I checked for Leap15 and also I mentioned in #2189
that `dhcp-send-hostname` is deprecated in favor of
`dhcp-send-hostname-v2`

## Testing

- *Added a new unit test*
- *Tested manually*
- *Tested with wicked2nm*

Run Details

92 of 132 branches covered (69.7%)

Branch coverage included in aggregate %.

0 of 46 new or added lines in 2 files covered. (0.0%)

16 existing lines in 2 files now uncovered.

11059 of 12405 relevant lines covered (89.15%)

59.75 hits per line