rust-bitcoin / rust-bitcoin / 15367558069

83%

push

github

Merge rust-bitcoin/rust-bitcoin#4571: Move `p2p` encodings from `encode` and into `p2p`

<a class=hub.com/rust-bitcoin/rust-bitcoin/commit/<a class="double-link" href="https://git"><a class=hub.com/rust-bitcoin/rust-bitcoin/commit/20779bdbc8ebcac2365d122e857c23b3d8e8d1e7">20779bdbc<a href="https://github.com/rust-bitcoin/rust-bitcoin/commit/2113a32276250da65e82d24b4e00cae9b9bf514a"> Move `p2p` encodings out of `encode` (rustaceanrob)
<a class="double-link" href="https://github.com/rust-bitcoin/rust-bitcoin/commit/94bcff28b19715061c38af418afd8f0b979792a8">94bcff28b</a> p2p: Add wrappers for messages that use `Vec` (rustaceanrob)

Pull request description:

  To move `p2p` into a crate:
  1. All `Encodable` implementations for `p2p` must be defined in `p2p`. To accomplish this, and anything else in the future related to encoding, I added a `deser` module with the necessary macro to implement `Encodable` for `Vec<T> where T: Encodable`.
  2. Because the orphan rule would apply for implementing `Encodable`for `Vec` within `p2p`, three types defined within `p2p` are used to wrap the `Vec` and snake around the orphan rule.

ACKs for top commit:
  tcharding:
    ACK 20779bdbc8ebcac2365d122e857c23b3d8e8d1e7
  apoelstra:
    ACK 20779bdbc8ebcac2365d122e857c23b3d8e8d1e7; successfully ran local tests

Tree-SHA512: 7abfe5b856f3426512d98d907905bc0d29c

31 of 31 new or added lines in 3 files covered. (100.0%)

23508 of 27843 relevant lines covered (84.43%)

15889.9 hits per line