rust-bitcoin / rust-bitcoin / 15365210028

83%

Build Type

push

github

Committed by apoelstra

Commit Message

Merge rust-bitcoin/rust-bitcoin#4468: Improve lock times - fix off-by-one bug

<a class=hub.com/rust-bitcoin/rust-bitcoin/commit/4ccecf5decfead9818b74fbdee73115c349e2f3e">4ccecf5de<a href="https://github.com/rust-bitcoin/rust-bitcoin/commit/6d8299e8b82735995fb58c4e2a51dbc830a748ef"> Fix stale Height type link (Tobin C. Harding)
<a class="double-link" href="https://github.com/rust-bitcoin/rust-bitcoin/commit/caebb1bf73ec34f0ca87c54a072a79f154ef853a">caebb1bf7</a><a href="https://github.com/rust-bitcoin/rust-bitcoin/commit/6d8299e8b82735995fb58c4e2a51dbc830a748ef"> units: relative: Do minor rustdocs fixes (Tobin C. Harding)
</a><a class="double-link" href="https://github.com/rust-bitcoin/rust-bitcoin/commit/40bb177bc2b75f976f24885ca69fc20591884cb4">40bb177bc</a><a href="https://github.com/rust-bitcoin/rust-bitcoin/commit/6d8299e8b82735995fb58c4e2a51dbc830a748ef"> Put is_satisfied_by functions together (Tobin C. Harding)
</a><a class="double-link" href="https://github.com/rust-bitcoin/rust-bitcoin/commit/480a2cd62aa5ddfea15cc1ccbf0e03f92bc663d9">480a2cd62</a><a href="https://github.com/rust-bitcoin/rust-bitcoin/commit/6d8299e8b82735995fb58c4e2a51dbc830a748ef"> Favour new function `from_mtp` over deprecated (Tobin C. Harding)
</a><a class="double-link" href="https://github.com/rust-bitcoin/rust-bitcoin/commit/f9d6453d5b2893fe6b025f05485ae71b04c3052e">f9d6453d5</a><a href="https://github.com/rust-bitcoin/rust-bitcoin/commit/6d8299e8b82735995fb58c4e2a51dbc830a748ef"> Shorten locktime type term (Tobin C. Harding)
</a><a class="double-link" href="https://github.com/rust-bitcoin/rust-bitcoin/commit/727047bd393f4616392a1966fd997526add35e33">727047bd3 Fix off-by-one-bug in absolute locktime (Tobin C. Harding)
3ffdc54ca Fix off-by-one bug in relative locktime (Tobin C. Harding)
a2ff8ddbb Improve relative::LockTime is_satisfied_by_{height, time} (Tobin C. Harding)

Pull request description:

  Make the APIs uniform in relative and absolute locktimes in relation to the `is_satisfied_by` functions. In doing so improve the API and fix an off-by-one bug when checking satisfaction of locks by height.

  Done in three patches but maybe should be squashed? Probably easiest to review by looking at all the `is_satisfied_by*` functions and convincing yourself we got it right.

  EDIT: Now has 5 cleanup patches also (mostly docs cleanups).

ACKs for top commit:
  apoelstra:
    ACK 4ccecf5decfead9818b74fbdee73115c349e2f3e; successfully ran local tests

Tree-SHA512: 9206cb464f6025196993a2a2a72538b7826

Coverage Stats

109 of 174 new or added lines in 4 files covered. (62.64%)

14 existing lines in 3 files now uncovered.

23485 of 27827 relevant lines covered (84.4%)

15894.02 hits per line