zalando / skipper / 15344503167

78%

Build Type

push

github

Committed by web-flow

Commit Message

eskip: reset parser before returning to the pool (#3516)

eskipLexParser references parsed code and parsed results.

Garbage collector will collect pooled eskipLexParser instances; this
change makes its job a tiny bit easier by eliminating any references
from pooled instances.

It also makes code canonical by using sync.Pool.New for constructing new
instances.

There is no change in performance or allocations as expected:
```
goos: linux
goarch: amd64
pkg: github.com/zalando/skipper/eskip
cpu: Intel(R) Core(TM) i5-8350U CPU @ 1.70GHz
                  │   master    │                HEAD                │
                  │   sec/op    │   sec/op     vs base               │
ParsePredicates-8   4.720µ ± 3%   4.594µ ± 3%       ~ (p=0.066 n=10)
Parse-8             163.6m ± 2%   164.3m ± 1%       ~ (p=0.912 n=10)
geomean             878.6µ        868.8µ       -1.12%

                  │    master    │                 HEAD                  │
                  │     B/op     │     B/op      vs base                 │
ParsePredicates-8   1.773Ki ± 0%   1.773Ki ± 0%       ~ (p=1.000 n=10) ¹
Parse-8             61.79Mi ± 0%   61.79Mi ± 0%       ~ (p=0.218 n=10)
geomean             335.0Ki        335.0Ki       -0.00%
¹ all samples are equal

                  │   master    │                 HEAD                 │
                  │  allocs/op  │  allocs/op   vs base                 │
ParsePredicates-8    50.00 ± 0%    50.00 ± 0%       ~ (p=1.000 n=10) ¹
Parse-8             1.510M ± 0%   1.510M ± 0%       ~ (p=1.000 n=10)
geomean             8.689k        8.689k       +0.00%
¹ all samples are equal

        │    master    │               HEAD               │
        │   bytes/op   │   bytes/op    vs base            │
Parse-8   15.99Mi ± 0%   15.99Mi ± 0%  ~ (p=1.000 n=10) ¹
¹ all samples are equal
```

Follow up on #2193

Signed-off-by: Alexander Yastrebov <alexander.yastrebov@zalando.de>

Run Details

7 of 7 new or added lines in 1 file covered. (100.0%)

86 existing lines in 2 files now uncovered.

23212 of 29862 relevant lines covered (77.73%)

101430.42 hits per line