skeema / skeema / 15312575569

92%

push

github

options: add some deprecation warnings ahead of v2

As per https://www.skeema.io/blog/skeema-v2-roadmap, several unnecessary
options will be removed in Skeema v2 later this year, and others will have
changes to their default values. Before that happens, these options need to
have appropriate warnings (and, where applicable, deprecations) in v1. This
commit starts that process.

These options are newly deprecated, and warnings will be emitted if they are
used on the command-line and/or in option files:

* alter-validate-virtual
* lint-display-width
* temp-schema-binlog

These ancient options were already deprecated, but now log deprecation
warnings upon any usage, consistent with the approach used for the other
options above:

* normalize (deprecated since v1.3.0 in Sept 2019)
* errors (deprecated since v1.3.0 in Sept 2019)
* warnings (deprecated since v1.3.0 in Sept 2019)
* reuse-temp-schema (deprecated since v1.4.0 in Nov 2019)

These options will have their default value changed in v2, and now log
warnings if they are not explicitly configured:

* format (option for `skeema lint` and `skeema pull`)
* new-schemas (option for `skeema pull`)

Note that this commit does not handle *all* planned option deprecations ahead
of v2. A few additional options may be deprecated in separate commits in the
near future.

30 of 30 new or added lines in 9 files covered. (100.0%)

10483 of 11252 relevant lines covered (93.17%)

1.11 hits per line