kobotoolbox / kpi / 15262015841

81%

master: 76%

push

github

fix(permissions): uncheckable permission checkboxes DEV-266 (#5798)

### 📣 Summary

After selecting "Manage collection" permission in Library's Sharing
Form, User can unselect all checkboxes (one at a time) beck into initial
empty state.

### 💭 Notes

`applyValidityRules` requires additional argument `assignablePerms`. We
use it to ensure that the rules are being applied based on permissions
that are currently being displayed/used in the UI. Nn Library we are
displaying only 3 permissions, but the code was applying rules based on
all 16 of them causing the bug.


### 👀 Preview steps

Bug template:
1. Go to "My Library"
2. Have a collection, block, or template
3. Use "Share" button (appears on the right on hover)
4. In "Sharing Permissions" modal use "Add user" button
5. In the form that appears check "Manage…" checkbox
6. 🟢 Notice that "View…" and "Edit…" are checked and disabled (this is
correct)
7. Uncheck "Manage…" checkbox
8. 🟢 Notice that "View…" checkbox is checked and disabled, and "Edit…"
checkbox is checked and (now) enabled
9. Uncheck "Edit…" checkbox
10. 🔴 (on main) Notice that "View…" checkbox is still checked and
disabled → it should be checked and enabled
11. 🟢 (on PR) Notice that "View…" checkbox is still checked, but not
disabled

6253 of 9913 branches covered (63.08%)

23851 of 29433 relevant lines covered (81.03%)

1.6 hits per line