umputun / spot / 15260566771

84%

Build Type

push

github

Committed by umputun

Commit Message

Fix preservation of single-quoted environment variables

This change addresses issue #285 where bcrypt passwords and other values
containing dollar signs were being corrupted when passed between commands
via environment variables.

The root cause was that when variables were exported with single quotes
(to prevent shell expansion), this intent was lost when the templater
substituted the values in subsequent commands.

Changes:
- Add exportKeyWithQuote method to detect single-quoted exports
- Mark single-quoted variables with :SQ suffix in setvar output
- Store single-quoted values with __SQ__: prefix internally
- Escape dollar signs during template substitution for SQ-marked values
- Update tests to handle new setvar format
- Add unit tests for templater handling of single-quoted values
- Update documentation to show correct single-quote approach

The fix ensures that when users export variables with single quotes like:
  export BCRYPT_PASSWORD='$2a$14$G.j2F3fm9wluTougUU52sOzePOvvpujjRrCoVp5qWVZ6qRJh58ISC'

The literal value is preserved throughout the variable lifecycle, preventing
shell expansion of special characters.

Also includes minor formatting fix in pkg/executor/remote.go.

Run Details

53 of 53 new or added lines in 3 files covered. (100.0%)

6 existing lines in 1 file now uncovered.

2860 of 3391 relevant lines covered (84.34%)

53.79 hits per line