wboayue / rust-ibapi / #137

86%

Build Type

push

Committed by web-flow

Commit Message

Fix subscription cancellation for market data snapshots (#236) (#251)

* Fix subscription cancellation for market data snapshots

Fixes issue #236 where market data snapshot subscriptions would
attempt to cancel after receiving SnapshotEnd, causing TWS to
respond with error 300 "Can't find EId with tickerId".

Changes:
- Added snapshot_ended field to Subscription to track when snapshots complete
- Modified process_message to detect SnapshotEnd for TickTypes subscriptions
- Updated Drop implementation to skip cancellation if snapshot has ended
- Added 'static bounds to DataStream trait for type safety

The fix ensures that:
- Market data snapshots automatically clean up after SnapshotEnd
- Streaming subscriptions continue to work as before
- No spurious error messages are generated
- Backward compatibility is maintained

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <noreply@anthropic.com>

* chore: cargo clippy

* refactor unsafe code

* refactor: snapshot_ended check

* chore: cleanup warnings

---------

Co-authored-by: Wil Boayue <wboayue@gmail.com>
Co-authored-by: Claude <noreply@anthropic.com>

Run Details

8 of 13 new or added lines in 2 files covered. (61.54%)

2 existing lines in 1 file now uncovered.

4125 of 4994 relevant lines covered (82.6%)

16.66 hits per line