rust-bitcoin / rust-bitcoin / 15214762049

83%

Build Type

push

github

Committed by apoelstra

Commit Message

Merge rust-bitcoin/rust-bitcoin#4538: Use `_u32` in `FeeRate` constructor instead of `_unchecked`

<a class=hub.com/rust-bitcoin/rust-bitcoin/commit/a1ce2d1ac8d646b63532ed9ac459ffea39ec8c20">a1ce2d1ac Use _u32 in FeeRate constructor instead of _unchecked (Tobin C. Harding)

Pull request description:

  When constructing an `Amount` it was observed recently that a `u32` is often big enough. For the same reason we can use a `u32` to construct a fee rate instead of overflowing.

  Use `_u32`in the constructor and remove the panic.

ACKs for top commit:
  apoelstra:
    ACK a1ce2d1ac8d646b63532ed9ac459ffea39ec8c20; successfully ran local tests

Tree-SHA512: 339974c95969f3785aa4b482e38036ca484

Coverage Stats

7 of 7 new or added lines in 2 files covered. (100.0%)

6 existing lines in 1 file now uncovered.

23651 of 27910 relevant lines covered (84.74%)

15910.96 hits per line