rust-bitcoin / rust-bitcoin / 15213230082

83%

Build Type

push

github

Committed by apoelstra

Commit Message

Merge rust-bitcoin/rust-bitcoin#4526: feat(p2p): add AddrV2 <> IpAddr conversions

<a class=hub.com/rust-bitcoin/rust-bitcoin/commit/<a class="double-link" href="https://git"><a class=hub.com/rust-bitcoin/rust-bitcoin/commit/3c920d1acb23d84976c0b8e632d8f1068ebbd1fd">3c920d1ac<a href="https://github.com/rust-bitcoin/rust-bitcoin/commit/2f2c9144ba1cbb369764b1ca978a019786bda5aa"> fix(p2p): Remove `SocketAddr::V6` <> `AddrV2::Cjdns` conversions (Erick Cestari)
<a class="double-link" href="https://github.com/rust-bitcoin/rust-bitcoin/commit/2c236ae24fbda928c35556a5961ef58aea5ecf4d">2c236ae24</a><a href="https://github.com/rust-bitcoin/rust-bitcoin/commit/2f2c9144ba1cbb369764b1ca978a019786bda5aa"> fuzz: Add p2p address round-trip fuzzing test (Erick Cestari)
</a><a class="double-link" href="https://github.com/rust-bitcoin/rust-bitcoin/commit/7ad89df3921f6bc794695569fc0dd5111901bdbb">7ad89df39</a><a href="https://github.com/rust-bitcoin/rust-bitcoin/commit/2f2c9144ba1cbb369764b1ca978a019786bda5aa"> test(p2p): add tests for `AddrV2` &lt;&gt; `IpAddr` conversions (Erick Cestari)
</a><a class="double-link" href="https://github.com/rust-bitcoin/rust-bitcoin/commit/e8a9a89e25158c3823004d54a803ae6efec08921">e8a9a89e2</a> feat(p2p): add `AddrV2` <> `IpAddr` conversions (Erick Cestari)

Pull request description:

  This PR adds conversion traits between `AddrV2` and standard IP types, inspired by #4519.

  ### Changelog

  - Implement `From<IpAddr>` for `AddrV2`.
  -  Implement `From<Ipv4Addr>` for `AddrV2`.
  -  Implement `From<Ipv6Addr>` for `AddrV2.`
  - Implement `TryFrom<AddrV2>` for `IpAddr`.
  - Implement `TryFrom<AddrV2>` for `Ipv4Addr`.
  - Implement `TryFrom<AddrV2>` for `Ipv6Addr`.
  - Implement `AddrV2ToIpAddrError` enum and it's `fmt::Display`.
  - Implement `AddrV2ToIpv4AddrError` enum and it's `fmt::Display`.
  - Implement `AddrV2ToIpv6AddrError` enum and it's `fmt::Display`.
  - Renamed `AddrV2ConversionError` to `AddrV2ToSocketAddrError`
  - Tests for `TryFrom` conversions.

ACKs for top commit:
  apoelstra:
    ACK 3c920d1acb23d84976c0b8e632d8f1068ebbd1fd; successfully ran local tests
  tcharding:
    ACK 3c920d1acb23d84976c0b8e632d8f1068ebbd1fd

Tree-SHA512: 6bc80072501cdf23677fc34e70df78fd588

Coverage Stats

159 of 188 new or added lines in 1 file covered. (84.57%)

2 existing lines in 2 files now uncovered.

23655 of 27909 relevant lines covered (84.76%)

15838.74 hits per line