agama-project / agama / 15211695453
73%

DEFAULT BRANCH: master
Ran
Jobs 3
Files 533
Run time 1min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
coverage: 62.836% (+0.04%) from 62.797%
15211695453

push

github

web-flow 
fix(rust): fix handling of secure WebSocket connections (#2391)

## Problem

Handling of the WebSocket was plain wrong:

- The "agama monitor" was always ignoring SSL problems.
- The "events monitor" was always trying to use TLS.

## Solution

- Rewrite the WebSocket::connect method to handle ws: and wss: as
expected.
- Disable `--insecure` for `agama monitor` by default.

## Testing

- *Tested manually*

92 of 132 branches covered (69.7%)

Branch coverage included in aggregate %.

0 of 3 new or added lines in 1 file covered. (0.0%)

35 existing lines in 5 files now uncovered.

11050 of 17600 relevant lines covered (62.78%)

40.11 hits per line

New Missed Lines in Diff

Lines Coverage ∆ File
3
0.0
 0.0% rust/agama-lib/src/http/websocket.rs

Uncovered Existing Lines

Lines Coverage ∆ File
2
0.0
 0.0% rust/agama-lib/src/http/websocket.rs
3
0.0
 0.0% rust/agama-server/src/web/common/issues.rs
7
0.0
 0.0% rust/agama-server/src/web/common.rs
9
0.0
 0.0% rust/agama-lib/src/monitor.rs
14
0.0
 0.0% rust/agama-server/src/web.rs
Subprojects
ID Flag name Job ID Ran Files Coverage
3 rust 15211695453.3 118
1.35
 GitHub Action Run
3 service 15211210428.3 379
89.12
 GitHub Action Run
3 web 15203364908.3 36
82.3
 GitHub Action Run
Source Files on build 15211695453