kobotoolbox / kpi / 15211135284

81%

master: 76%

push

github

fix(permissions): sharing modal correctly reflects asset type in permissions labels DEV-255 (#5736)

### 📣 Summary
<!-- Delete this section if changes are internal only. -->
<!-- One sentence summary for the public changelog, worded for
non-technical seasoned Kobo users. -->

Fixes a bug where the sharing modals will always display "form" or
"project" regardless of asset type. Now the modal correctly references
the asset being shared.

### 👀 Preview steps
<!-- Delete this section if behavior can't change. -->
<!-- If behavior changes or merely may change, add a preview of a
minimal happy path. -->

1. Create a project, and a few library items:
  - a single question
  - a question block
  - a template
  - a collection 
3. Open the sharing modal for each of the above
4. 🔴 [on main] notice that the permissions displayed is not correctly
reflected based on the type of asset being shared
5. 🟢 [on PR] notice that the permissions displayed change according to
the asset type being shared

---------

Co-authored-by: Leszek Pietrzak <leszek@magicznyleszek.xyz>
Co-authored-by: Leszek <smutnyleszek@gmail.com>

6254 of 9913 branches covered (63.09%)

23854 of 29433 relevant lines covered (81.05%)

1.6 hits per line