agama-project / agama / 15210279558

73%

Build Type

push

github

Committed by web-flow

Commit Message

feat: non-blocking and centralized progress reporting (#2389)

## Problem

Follow-up of #2379.

It is a known problem that the software service can get blocked at
several stages and it has an impact in the UI and the CLI. We handled
part of that problem in #2364 and #2379, but there are still some cases
that are not handled properly.

For instance, during software probing, Agama is not able to return the
current progress.

## Solution

This PR implements a new `ProgressService` which handles and caches the
progress for any service.

Apart from caching the progress, it offers a centralized way of keeping
track of the progress, listening for changes in single place (instead of
building and processing an stream of events for each of the services).

The service uses [Tokio
channels](https://tokio.rs/tokio/tutorial/channels) and message passing
to [share the state](https://tokio.rs/tokio/tutorial/shared-state).

As part of this change, I have decided to introduce a new
`ProgressChanged` signal, which carries the information we need, instead
of relying on the generic `PropertiesChanged`.

## Testing

- Tested manually
- An ISO is [temporarily
available](https://download.opensuse.org/repositories/systemsmanagement:/Agama:/branches:/non-blocking-progress/images/iso/).

Run Details

92 of 132 branches covered (69.7%)

Branch coverage included in aggregate %.

11 of 31 new or added lines in 4 files covered. (35.48%)

85 existing lines in 5 files now uncovered.

11040 of 17601 relevant lines covered (62.72%)

39.85 hits per line