agama-project / agama / 15191629254

72%

Build Type

push

github

Committed by web-flow

Commit Message

feat: non-blocking and centralized issues (#2379)

## Problem

It is a known problem that the software service can get blocked at
several stages and it has an impact in the UI and the CLI. We mitigated
that problem in #2364 but there are still some cases that are not
handled properly.

For instance, during software probing, Agama is not able to return the
list of issues. we could argue whether the list of issues is still
valid, but that's a different topic. At least, Agama should return
something.

## Solution

This PR implements a new `IssuesService` which handles and caches the
issues for any service. At this point, it is only used by the software
service, but the idea is to use it from all the services.

Apart from caching the issues, it offers a centralized way of keeping
track of the issues, listening for changes in single place (instead of
building and processing an stream of events for each of the services).
For instance, the iSCSI API was not emitting the `IssuesChanged` events
because we forgot to add the call to `issues_stream`. Now, it is done
automatically.

The service uses [Tokio
channels](https://tokio.rs/tokio/tutorial/channels) and message passing
to [share the state](https://tokio.rs/tokio/tutorial/shared-state).

> [!NOTE]
> The problem is not fully solved because the "can_install" function
still relies on D-Bus, which still blocks.

## Testing

- Tested manually

## Tasks

- [x] Implement an IssuesService.
- [x] Emit the events from the service itself.
- [x] Adopt `IssuesService` in other services.

## Follow ups

Most probably, we should implement a mechanism like this for progress
tracking too, although given to the amount of progress signals it is
rarely a problem.

Run Details

92 of 132 branches covered (69.7%)

Branch coverage included in aggregate %.

0 of 35 new or added lines in 5 files covered. (0.0%)

24 existing lines in 1 file now uncovered.

10949 of 17498 relevant lines covered (62.57%)

42.73 hits per line