dnsimple / erldns / 15111792331

88%

Build Type

push

github

Committed by web-flow

Commit Message

Rework instrumentation to use telemetry (#213)

Integrates telemetry with a special event for response times, see erldns_worker_process:measure_time/4, which gets an initial timestamp that was created all the way back in the erldns_tcp_server and erldns_udp_server.

In this architecture, erldns becomes metrics agnostic. Note that all folsom related disappears from here (they're moved to the parent application). It doesn't even know that metrics are supposed to be captured, it's only emitting abstract events identified by a name, measurements (counts or timestamps), and metadata (udp/tcp, dnssec, etc). It becomes the responsibility of the parent application to subscribe to these telemetry events and give them meaning, in our case, transform them into useful metrics, see dnsimple/erldnsimple#467.

Coverage Stats

33 of 50 new or added lines in 7 files covered. (66.0%)

138 existing lines in 8 files now uncovered.

1015 of 1776 relevant lines covered (57.15%)

475.88 hits per line