dnsimple / dns_erlang / 15111319503

84%

Build Type

push

github

Committed by web-flow

Commit Message

Rewrite most of the encode/decode logic (#72)

1. Use maps for options, as they can be typed and have better
   performance characteristics than proplists.
2. Use `erlang:system_time/1` for timestamps, for way better performance
   and no garbage-collection needed.
3. Split encode and decode logic into separate helper modules, to keep
   modules more manageable in size and responsibilities.
4. Reimplement decoding logic to always keep the input binary as the
   first argument, to help with BEAM registry allocation.
5. Reimplement encoding logic to always build responses that contain the
   full question section, and optionally drop the answers if the
   response is to be truncated.
6. Split TSIG functionality to a dedicated module.

It also fixes the ex_doc generation (a binary was defined as <<_:6 * 8>>, which the Elixir AST compiler in the most recent version fo ExDoc failed to quote, should have been <<_:48>>.

Also, tackles #19, reorganises and extends documentation, and increments code coverage considerably.

Run Details

749 of 901 new or added lines in 7 files covered. (83.13%)

6 existing lines in 2 files now uncovered.

1127 of 1417 relevant lines covered (79.53%)

851.41 hits per line