dnsimple / dns_erlang / 15106205305

85%

Build Type

push

github

Committed by web-flow

Commit Message

Escape backslashes too (#28)

When a packet is received with a query for \\.test (that is, a name with
two labels, one composed of only a backslash character, and the label
“test”), labels_to_dname() decodes it to "\\.test". Calling
dname_to_labels() again on that result yields \.test (that is, a name
with one label, “.test”) instead of \\.test.

The solution is to also backslash-escape the backslash character.

This commit also adds corresponding unit tests to that effect.

Run Details

10 of 10 new or added lines in 1 file covered. (100.0%)

48 existing lines in 1 file now uncovered.

1037 of 1405 relevant lines covered (73.81%)

1342.4 hits per line