rust-bitcoin / rust-bitcoin / 15076355283

83%

push

github

Merge rust-bitcoin/rust-bitcoin#4508: units: Make block-related types have private inner fields

<a class=hub.com/rust-bitcoin/rust-bitcoin/commit/9a9b41008f72cb8a00cfed2890d839aea2ea27c7">9a9b41008 units: Make block-related types have private inner fields (Tobin C. Harding)

Pull request description:

  We recently added a bunch of types in the `block` module that are wrappers around `u32`. When we did we slapped `pub` on the inner fields.

  Lets be more mindful and make the inner fields private. Note all these types have `to_u32`, `from_u32` and `From` in both directions.

ACKs for top commit:
  apoelstra:
    ACK 9a9b41008f72cb8a00cfed2890d839aea2ea27c7; successfully ran local tests

Tree-SHA512: d4719bef5b2442637912b78b9d7c25329b3

23334 of 27577 relevant lines covered (84.61%)

16008.14 hits per line