rust-bitcoin / rust-bitcoin / 15075742242

83%

Build Type

push

github

Committed by apoelstra

Commit Message

Merge rust-bitcoin/rust-bitcoin#4503: Fix up script to/from hex

<a class=hub.com/rust-bitcoin/rust-bitcoin/commit/2c0f3881085ba540d517de121d4ba005f9e73a8c">2c0f38810 Fix up script to/from hex (Tobin C. Harding)

Pull request description:

  We (I) have recently done to PRs patching the way we handle converting scripts to and from hex.

  In doing these I made a mess of the deprecation because after both PRs were in I had managed to change the return type and the behaviour of the deprecated function.

  On top of that the docs were either outright wrong or not that clear.

  Props to Kix for doing post merge review and finding my mistakes.

  Close #4498

ACKs for top commit:
  apoelstra:
    ACK 2c0f3881085ba540d517de121d4ba005f9e73a8c; successfully ran local tests

Tree-SHA512: 8bd8590c05a11e4a1b2628b12eb41f6654b

Coverage Stats

0 of 3 new or added lines in 2 files covered. (0.0%)

1 existing line in 1 file now uncovered.

23333 of 27577 relevant lines covered (84.61%)

16128.32 hits per line